Skip to content

Change auto-formatting settings #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2021
Merged

Change auto-formatting settings #548

merged 1 commit into from
Sep 4, 2021

Conversation

japgolly
Copy link
Contributor

@japgolly japgolly commented Sep 4, 2021

Part of #479. Not the whole thing and it's still pretty far from perfect, but it's an improvement :)

@japgolly japgolly requested a review from armanbilge September 4, 2021 04:13
armanbilge
armanbilge approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is!! So, just confirming, from this point forward no more merges from series/1.x?

@japgolly
Copy link
Contributor Author

japgolly commented Sep 4, 2021

Yeah I don't think so, especially if we get 2.0.0 out soon

@japgolly japgolly merged commit 25d2ace into master Sep 4, 2021
@japgolly japgolly deleted the topic/reformat branch September 4, 2021 04:28
@armanbilge
Copy link
Member

That's great!! Yes let's keep pushing to 2.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@japgolly @armanbilge