Improve DOM_KEY_LOCATION_* bindings

[tindzk]

The current naming of the object KeyboardEvent is slightly unfortunate as it only contains constants related to key locations.

Other wrappers call this object KeyLocation:

• https://api.dartlang.org/stable/1.24.3/dart-html/KeyLocation-class.html
• https://vaadin.com/api/7.6.5/elemental/events/KeyboardEvent.KeyLocation.html

For compatibility reasons, I kept the object and defined aliases in ext.

I was also considering to drop js.native since the standard defines the constants as follows:

val DOM_KEY_LOCATION_STANDARD = 0x00
val DOM_KEY_LOCATION_LEFT     = 0x01
val DOM_KEY_LOCATION_RIGHT    = 0x02
val DOM_KEY_LOCATION_NUMPAD   = 0x03

[sjrd]

Could you integrate the reformattings in the individual commits, please? Each commit should be green on the CI.

[tindzk]

Thanks, @sjrd. I rebased the pull request.

What do you think about moving the constants from KeyboardEvent to the global scope (package.scala)?

[sjrd]

What do you think about moving the constants from KeyboardEvent to the global scope (package.scala)?

Why would we do that?

[tindzk]

Thanks for merging!

Why would we do that?

The constants are also in the global scope in JavaScript.

[sjrd]

That doesn't appear to be the case, at least in Firefox: trying DOM_KEY_LOCATION_STANDARD in the browser console yields

ReferenceError: DOM_KEY_LOCATION_STANDARD is not defined

whereas KeyboardEvent.DOM_KEY_LOCATION_STANDARD works.

[tindzk]

Indeed. In that case, we can keep the object as-is.