Multiple parameters list formatting #99
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactor code.
|
Matt Russell » scalariform #35 SUCCESS |
Contributor
Author
|
Threshold: done. |
|
Matt Russell » scalariform #36 FAILURE |
Contributor
|
👍, I'd love that feature. Kudos, Lukasz. |
|
Matt Russell » scalariform #37 SUCCESS |
Member
|
Thanks for that 👍 I hope this will be merged soon :) |
commit 0fda9eaecc7393d64745a9bec8cec0284ecca07d Author: Daniel Trinh <[email protected]> Date: Fri Jan 17 18:02:37 2014 -0800 add comment commit 5880b99 Author: Daniel Trinh <[email protected]> Date: Fri Jan 17 18:00:04 2014 -0800 update the readme commit 95dd966 Author: Daniel Trinh <[email protected]> Date: Fri Jan 17 17:30:17 2014 -0800 fixed all remaining edgecases, specs are passing 100% commit dcab3d5 Author: Daniel Trinh <[email protected]> Date: Thu Jan 16 23:56:48 2014 -0800 restructured new formatting code commit a7b1bef Author: Daniel Trinh <[email protected]> Date: Thu Jan 16 08:46:15 2014 -0800 more temp work commit 2dd4271 Author: Daniel Trinh <[email protected]> Date: Thu Jan 16 00:10:57 2014 -0800 first attempt at getting relative PlaceAtColumn working commit dacd43c Author: Daniel Trinh <[email protected]> Date: Wed Jan 15 17:53:49 2014 -0800 fix remaining alignment bugs commit 575513c Author: Daniel Trinh <[email protected]> Date: Wed Jan 15 08:51:49 2014 -0800 more corner case tweaking and temporary work commit 7f57468 Author: Daniel Trinh <[email protected]> Date: Tue Jan 14 23:23:58 2014 -0800 more small bugfixes and temp work commit c9fd4f3 Author: Daniel Trinh <[email protected]> Date: Tue Jan 14 17:34:17 2014 -0800 more temp work commit dd0c257 Author: Daniel Trinh <[email protected]> Date: Tue Jan 14 13:58:52 2014 -0800 fixed a bug with first parameter not being placed onto a newline commit 67129ba Author: Daniel Trinh <[email protected]> Date: Mon Jan 13 14:08:03 2014 -0800 more temp work. it is starting to come together commit 6571b52 Author: Daniel Trinh <[email protected]> Date: Mon Jan 13 00:14:48 2014 -0800 more temp work commit f43051b Author: Daniel Trinh <[email protected]> Date: Fri Jan 10 17:38:41 2014 -0800 more temporary work commit b9a3b1d Author: Daniel Trinh <[email protected]> Date: Wed Jan 8 23:52:15 2014 -0800 add a few tweaks to prefix length calculation commit 93b6990 Author: Daniel Trinh <[email protected]> Date: Wed Jan 8 17:39:33 2014 -0800 more temp work commit 86f8489 Author: Daniel Trinh <[email protected]> Date: Tue Jan 7 17:26:43 2014 -0800 more temporary work commit 02c465c Author: Daniel Trinh <[email protected]> Date: Tue Jan 7 00:36:58 2014 -0800 adding very broken WIP code
Update alignParams to support aligning types and defaults. Dangling parenthesis with 0 parameters is still broken.
Conflicts: scalariform/src/main/scala/scalariform/formatter/ExprFormatter.scala
…f `import a.b.c.{d, e, f}` into `import a.b.c.{ d, e, f }`. Especially for Java experienced coders this looks more natural.
…e java swing libraries from JDK6 to JDK7. This shouldn't be a problem for using this library on JDK6, though, since the bytecode should be the same... so the jdk6 build in travis is being removed
… the rule for method calls. specs still need to be fixed
…nts and auto dangling parenthesis
…xtra indentation in consecutive param clauses
Unify multi line method and parameter formatting
Conflicts: scalariform/src/main/scala/scalariform/formatter/ExprFormatter.scala scalariform/src/main/scala/scalariform/formatter/preferences/PreferenceDescriptor.scala
|
Matt Russell » scalariform #46 FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I start to implement #73. It is not fully working PR but I create it to prevent duplication of work.
I want add next formatting property which will describe maximum line length for groups parameters before start to breaking it to next line.