Skip to content

Add modifierWhitelist option #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

cgewecke
Copy link
Member

@cgewecke cgewecke commented Jan 6, 2021

Option accepts a list of strings (simple modifier names like nonReentrant) to exclude from modifier branch coverage.

This is useful for modifiers that perform non-branch preparatory work.

Ex: synthetix/Proxyable:optionalProxy

    modifier optionalProxy {
        _optionalProxy();
        _;
    }


    function _optionalProxy() private {
        if (Proxy(msg.sender) != proxy && Proxy(msg.sender) != integrationProxy && messageSender != msg.sender) {
            messageSender = msg.sender;
        }
    }

@cgewecke cgewecke mentioned this pull request Jan 6, 2021
40 tasks
@cgewecke cgewecke merged commit ecde305 into experimental-options Jan 6, 2021
@cgewecke cgewecke deleted the modifier-whitelist branch January 6, 2021 03:10
cgewecke added a commit that referenced this pull request Apr 26, 2022
cgewecke added a commit that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant