Pr implement reconcile certs #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds MachineDeployment template as in cluster-api-provider-aws.
per discussion , deployment has sideeffect such as potential race condition, so need switch to statefulset.
4 tasks
centos generate has some issue, missed commands=>files changes
jichenjc
reviewed
Jul 10, 2019
jichenjc
reviewed
Jul 10, 2019
| type KeyPair struct { | ||
| // base64 encoded cert and key | ||
| Cert []byte `json:"cert"` | ||
| Key []byte `json:"key"` |
jichenjc
reviewed
Jul 11, 2019
|
|
||
| // ReconcileCertificates generate certificates if none exists. | ||
| func (s *Service) ReconcileCertificates(clusterName string, clusterProviderSpec *v1alpha1.OpenstackClusterProviderSpec) error { | ||
| if !clusterProviderSpec.CAKeyPair.HasCertAndKey() { |
There was a problem hiding this comment.
from code, looks like you are trying to generate those keys? if it's generated, then how do you store them and reuse? looks to me the Spec are the desired state but if you didn't give key at beginning, it's not desired state?? just curious ..
Owner
Author
There was a problem hiding this comment.
I'll move this PR and your comment over to the kubernetes-sigs repo now that the first PR is merged :)
Owner
Author
There was a problem hiding this comment.
upgrade klog from 0.1 to 0.3 to avoid no log issue
* factored out services These changes are heavily inspired by CAPA. They should improve the structure of the code for the upcoming addition of multi-node control plane support. * fix tests
This is heavily inspired bei CAPA. We now reconcile and store certificates in the Cluster CRD. Thus it's possible to distribute the same CAs over all control plane nodes (as soon as multi-node control plane supported is implemented). We also don't have to ssh on the/a control plane node to get a valid kubeconfig. We now can just generate one from the CA.
… controllerClient This enables us to run the controller outside the Workload Cluster, e.g. in a Management Cluster.
Now it's possible to use a local userdata folder. This is mostly useful for development to avoid updating the user data Secrets all the time.
sbueringer
force-pushed
the
pr-implement-reconcile-certs
branch
from
bb70c66 to
d0bb419
Compare
Owner
Author
|
Moved to kubernetes-sigs#394 |
sbueringer
pushed a commit
that referenced
this pull request
Feb 22, 2021
* Makefile: add GOPROXY to docker-build build-arg * add go version for running go env GOPROXY in Makefile * add caas owners, simplify PR template * use caas specific version for GIT_VERSION * use mirrored golang image * add kore team as owners * update README * use Go 1.15.8 from Harbor registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: