-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Fix for 2 vulnerabilities #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-VALIDATOR-13395830 - https://snyk.io/vuln/SNYK-JS-TYPEORM-13746469
Summary of ChangesHello @saurabharch, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two identified medium-severity vulnerabilities. The changes involve updating core npm dependencies, specifically Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades class-validator and typeorm to resolve two security vulnerabilities. While necessary, the upgrade to typeorm v0.3.x introduces significant breaking changes. The BaseEntity.findOne(id) method is no longer supported, which will cause runtime errors in ChangePassword.ts and Me.ts. I have left a critical comment on the package.json file detailing the required code modifications to ensure the application remains functional after this dependency upgrade. Please address these issues before merging.
| "reflect-metadata": "^0.1.13", | ||
| "type-graphql": "^0.16.0", | ||
| "typeorm": "^0.2.12", | ||
| "typeorm": "^0.3.26", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upgrade of typeorm to version 0.3.x is a major update with breaking changes. The BaseEntity.findOne(id) method, which was used to find an entity by its primary key, has been removed.
This will cause runtime errors in the following files:
-
src/modules/user/ChangePassword.tson line 26:const user = await User.findOne(userId);
The
userIdis a string from Redis. This should be updated to:const user = await User.findOneBy({ id: parseInt(userId, 10) });
-
src/modules/user/Me.tson line 14:return User.findOne(ctx.req.session!.userId);
This should be updated to:
return User.findOneBy({ id: ctx.req.session!.userId });
These changes are required to make the application work with the new version of typeorm. Please apply these fixes in a follow-up commit to this PR.
Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-VALIDATOR-13395830
SNYK-JS-TYPEORM-13746469
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection