[Snyk] Security upgrade type-graphql from 0.16.0 to 1.0.0

[saurabharch]

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

• package.json
• package-lock.json

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Improper Validation of Specified Type of Input SNYK-JS-VALIDATOR-13395830	541

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

[gemini-code-assist]

Summary of Changes

Hello @saurabharch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by performing a major version upgrade of the type-graphql dependency from 0.16.0 to 1.0.0. This upgrade is crucial for mitigating a medium-severity vulnerability concerning improper input validation, ensuring the application benefits from the latest security patches and features provided by the updated library.

Highlights

• Dependency Upgrade: Upgraded the type-graphql dependency from version 0.16.0 to 1.0.0.
• Security Fix: Addressed a medium-severity vulnerability (SNYK-JS-VALIDATOR-13395830) related to 'Improper Validation of Specified Type of Input' by updating type-graphql.
• Transitive Dependency Updates: Updated various transitive dependencies and their lock file entries in package-lock.json to align with the new type-graphql version and resolve the identified security issue.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, upgrades type-graphql from 0.16.0 to 1.0.0 to fix a security vulnerability. This is a major version upgrade and introduces breaking changes that will impact your project.

My review has identified a critical issue. The formatArgumentValidationError function, used in src/index.ts, has been removed in this new version of type-graphql. This will break your server's validation error handling. I have added a comment to package.json explaining the issue and providing a code example for the necessary fix. After addressing this breaking change, the upgrade should be safe to merge.

[gemini-code-assist]

Upgrading type-graphql to a new major version (1.0.0) introduces breaking changes that will affect your project.

The function formatArgumentValidationError has been removed from type-graphql since v0.17.0. Your code in src/index.ts at line 23 uses this function to format validation errors for Apollo Server, and it is imported on line 4. This will cause a runtime error as the function is no longer exported.

To fix this, you will need to:

1. Remove the import of formatArgumentValidationError from src/index.ts.
2. Provide a custom formatError function to the ApolloServer constructor.

Here is an example of how you can implement the formatError function in src/index.ts:

import { GraphQLError } from "graphql";
import { ArgumentValidationError } from "type-graphql";
// ... other imports

// ... in main function
const apolloServer = new ApolloServer({
    schema,
    formatError: (error: GraphQLError) => {
        const originalError = error.originalError;
        if (originalError instanceof ArgumentValidationError) {
            // You can customize the error response here.
            // For example, to expose validation errors:
            return {
                message: error.message,
                locations: error.locations,
                path: error.path,
                extensions: {
                    code: 'GRAPHQL_VALIDATION_FAILED',
                    validationErrors: originalError.validationErrors,
                }
            };
        }
        return error;
    },
    context: ({ req, res }: any) => ({ req, res })
});

This change is necessary for your application to handle validation errors correctly after the upgrade. Without it, your server's error handling for GraphQL validation will be broken.