Skip to content

[Snyk] Security upgrade express-session from 1.15.6 to 1.18.2 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade express-session from 1.15.6 to 1.18.2 #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"connect-redis": "^3.4.0",
"cors": "^2.8.5",
"express": "^4.16.4",
"express-session": "^1.15.6",
"express-session": "^1.18.2",
Copy link

@gemini-code-assist gemini-code-assist bot Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

As noted in the pull request description, the package-lock.json file has not been updated. This is a critical omission, as the lock file ensures that the exact same dependency versions are installed across all environments, guaranteeing reproducible builds.

Without an updated lock file, the security fix this PR intends to apply might not be consistently installed. Please run npm install to generate the updated package-lock.json and commit it to this branch before merging.

Copy link

@gemini-code-assist gemini-code-assist bot Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading express-session to version 1.18.2 is a good step for security. However, the corresponding TypeScript type definitions in devDependencies are now out of sync. The @types/express-session package is still at ^1.15.11.

This mismatch can lead to build failures, incorrect autocompletion, and potential runtime errors if the API has changed between versions. To maintain type safety, please upgrade the types package as well. You should update @types/express-session in your package.json to a compatible version, such as ^1.18.0, and then run npm install.

"graphql": "^14.1.1",
"graphql-query-complexity": "^0.2.3",
"ioredis": "^4.6.2",
Expand Down