[Snyk] Security upgrade nodemailer from 2.7.2 to 4.0.1

[saurabharch]

Snyk has created this PR to fix 2 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

• package.json

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Server-side Request Forgery (SSRF) SNYK-JS-IP-12704893	788
	Server-side Request Forgery (SSRF) SNYK-JS-IP-12761655	788

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Server-side Request Forgery (SSRF)

[gemini-code-assist]

Summary of Changes

Hello @saurabharch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's security posture by upgrading the nodemailer dependency to a more secure version. This update directly mitigates two high-severity Server-side Request Forgery (SSRF) vulnerabilities, ensuring the application is protected against these critical risks. The change was automatically initiated by Snyk.

Highlights

• Security Upgrade: This pull request was automatically generated by Snyk to address critical security vulnerabilities in the project's dependencies.
• Dependency Update: The nodemailer package has been upgraded from version 2.7.2 to 4.0.1.
• Vulnerability Fixes: Two high-severity Server-side Request Forgery (SSRF) vulnerabilities (SNYK-JS-IP-12704893 and SNYK-JS-IP-12761655) have been resolved with this upgrade.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request upgrades nodemailer from version 2.7.2 to 4.0.1 to fix security vulnerabilities. This is a major version upgrade and introduces breaking changes. The current usage of nodemailer in server/app/routes/api/v1/assessments/assessments.js is incompatible with version 4 and will lead to runtime errors. The code needs to be updated to reflect the API changes in nodemailer v4. Additionally, the nodemailer-smtp-transport package is now obsolete and can be removed.

[gemini-code-assist]

This upgrade to nodemailer v4 is a major version bump and introduces breaking changes. The existing code that uses this package, located in server/app/routes/api/v1/assessments/assessments.js, is not compatible with this new version and will break the email functionality.

To fix this, you'll need to make the following changes:

1. Update nodemailer initialization: sendMail now returns a promise by default in v4, so Promise.promisifyAll is no longer necessary.
2. Remove nodemailer-smtp-transport: This package (on line 60) is deprecated. Its functionality is now built into nodemailer. You should remove it from the dependencies.
3. Update transport creation: The transport creation logic needs to be updated to match the v4 API.

Here is an example of how to update server/app/routes/api/v1/assessments/assessments.js:

// In server/app/routes/api/v1/assessments/assessments.js

// Replace these lines:
// const nodemailer = Promise.promisifyAll(require("nodemailer"));
// const smtpTransport = require("nodemailer-smtp-transport")
// const transport = nodemailer.createTransport(smtpTransport(`smtps://${GMAIL_ID}:${GMAIL_PASSWORD}@smtp.gmail.com`));

// With:
const nodemailer = require("nodemailer");
const transport = nodemailer.createTransport({
    service: 'gmail',
    auth: {
        user: GMAIL_ID,
        pass: GMAIL_PASSWORD
    }
});

Without these changes, the application will fail to send emails after this dependency upgrade.