Skip to content

[Snyk] Security upgrade gulp-sass from 2.3.2 to 5.0.0 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade gulp-sass from 2.3.2 to 5.0.0 #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"gulp-notify": "^2.2.0",
"gulp-plumber": "^0.6.6",
"gulp-rename": "^1.2.0",
"gulp-sass": "^2.0.4",
"gulp-sass": "^5.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade from gulp-sass v2 to v5 introduces breaking changes that will cause your production build to fail. To fix the build, you need to:

  1. Add sass as a dependency: gulp-sass v5 requires the sass package (Dart Sass) as a peer dependency. Add it to devDependencies.

  2. Update gulpfile.js: The initialization of gulp-sass in gulpfile.js (line 8) must be updated to:

var sass = require('gulp-sass')(require('sass'));

Without these changes, the buildCSSProduction gulp task will fail.

"gulp-sourcemaps": "^1.3.0",
"gulp-uglify": "^1.1.0",
"history": "^3.0.0",
Expand Down