This repository was archived by the owner on Jul 24, 2024. It is now read-only.
Fix npm rebuild #1885
Merged
Fix npm rebuild #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `npm rebuild node-sass` as we instruct people, has been noop for a while. I'm not entirely sure what has changed. Debugging as reveal that running `rebuild` now just triggers the `install` and `postinstall` scripts. The `build` script is no longer run. This suggests something has changed in newer versions of npm. Since the `--force` flag is required to rebuild the binary I've update the `build` script to take into account if `--force` was passed to npm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
npm rebuild node-sassas we instruct people, has beennoop for a while. I'm not entirely sure what has changed.
Debugging has revealed that running
rebuildnow just triggers theinstallandpostinstallscripts. Thebuildscript is nolonger run. This suggests something has changed in newer versions
of npm.
Since the
--forceflag is required to rebuild the binary I'veupdate the
buildscript to take into account if--forcewaspassed to npm.