refactor(*): migrate code tabs to automatic conversion plugin #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sapphiredev/website/2SxwnK2V7a1emLYoR6uLC4DuNmvB |
vladfrangu
approved these changes
Nov 26, 2021
Co-authored-by: Vlad Frangu <[email protected]>
…ome months in the dark! permalink: http://whatthecommit.com/5b532ff7b60fed91dcbb2daae4fec3d9
favna
force-pushed
the
refactor/use-ts2esm2cjs-plugin
branch
from
f514e84 to
0f3b53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we do run into the caveat of this being an issue: microsoft/TypeScript#843Right now there doesn't seem to be a good solution. There's an open PR that aims to solve it (microsoft/TypeScript#42303) but we shouldn't let that hold us back from making this change because the currentTabsstyle is unmaintainable and is making writing guides extremely hard.The caveat above has been resolved