Add list user packages and delete user package #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glenn1001
reviewed
Sep 18, 2025
src/Domain/AccountPackage.php
Outdated
| 'isFree' => $this->isFree, | ||
| 'billingPeriodMonths' => $this->billingPeriodMonths, | ||
| 'isActive' => $this->isActive, | ||
| 'package' => $this->package, |
There was a problem hiding this comment.
Currently with the toArray call, I myself would expect that would be done recursively. If you do agree on this, then I would make the following change:
Suggested change
| 'package' => $this->package, | |
| 'package' => $this->package->toArray(), |
If you do not agree, then keeping it like it is, is no problem.
Author
There was a problem hiding this comment.
I agree, as some of them can be null I made some null safe, resolving the one below as well as it is the same
glenn1001
approved these changes
Sep 18, 2025
MrSandKurt
approved these changes
Sep 19, 2025
glenn1001
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add list user packages and delete user packages from basekit.
Doc: https://basekit.stoplight.io/docs/basekit/vkmfmoy8dbcvg-list-users-account-packages
I use the old object way to keep it consistent with the rest of the codebase.
Have to ignore baseline 4 times as the interface expects static which isn't always the case as these can be placed in a multidimensional array as well.