Avoid custom MCU definition being redefined as NRF52832 #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CPP Define NRF52 becomes defined in the
nrf5.pyfile (by"%s" % board.get("build.mcu", "")[0:5].upper(),)This definition sets the MCU to NRF52832 for backwards compatibility.
The NRF52840 has 2 GPIO ports (P0 with 32 GPIOs and P1 with 16 GPIOs)
Using an NRF52840 MCU on a custom board or the NRF52_dk (PCA10056) board results in only being able to access P0 due to the MCU being defined as NRF52832, resulting in GPIO_COUNT == 1
This does not allow the P1 pins to be accessed (P1.00 > P1.15)
These pins are used for the Arduino style header on the PCA10056 board.
This fix checks for an existing MCU definition and will not redefine this as NRF52832 (which only has as single GPIO port)