Skip to content

Conversation

@brunoamaral
Copy link

Link to related issue (if applicable)

#1723

Summary of proposed changes

The height setting doesn't work well with Bootstrap, removing it fixes the problem.

Checklist

  • Use develop as the base branch
  • Exclude the gulp build (/dist changes) from the PR
  • Test on supported browsers

@skerbis
Copy link
Contributor

skerbis commented Nov 3, 2020

same for UiKit

@sampotts sampotts changed the base branch from master to develop November 4, 2020 10:55
@sampotts
Copy link
Owner

sampotts commented Nov 13, 2020

Will merge this one manually. Thanks @brunoamaral !

@sampotts sampotts closed this Nov 13, 2020
@brunoamaral
Copy link
Author

My pleasure, @sampotts ! 🙇

@shravan2x
Copy link
Contributor

shravan2x commented Nov 17, 2020

@brunoamaral @skerbis I'm the person who initially added the height: 100% in the linked PR above. Without it, the video overflows the Plyr component.

When using with Bootstrap or UIKit, could you try wrapping the Plyr container in a div?

@brunoamaral
Copy link
Author

brunoamaral commented Nov 17, 2020

Hi @shravan2x , here's the code I am using right now, with the updated version of plyr:

<div class="plyr__video-embed player">
<iframe src="https://www.youtube.com/embed/rHKwIYsPXLg?origin=https://plyr.io&iv_load_policy=3&modestbranding=1&playsinline=1&showinfo=0&rel=0&enablejsapi=1" 
allowfullscreen allowtransparency=true allow=autoplay loading=lazy>
</iframe>
</div>

The result is in this link: https://brunoamaral.eu/post/algorithms-artificial-intelligence-and-us/

It seems to work well, is your suggestion to add another div around that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants