Darwin - Missing support

[noelmcloughlin]

Need support for Darwin (MacOS).

[ERROR   ] Rendering exception occurred: Jinja variable 'dict object' has no attribute 'main_config_template'
[CRITICAL] Rendering SLS 'base:tomcat.config' failed: Jinja variable 'dict object' has no attribute 'main_config_template'
[ERROR   ] Rendering exception occurred: Jinja variable 'dict object' has no attribute 'native_pkg'
[CRITICAL] Rendering SLS 'base:tomcat.native' failed: Jinja variable 'dict object' has no attribute 'native_pkg'
[ERROR   ] Rendering exception occurred: Jinja variable 'dict object' has no attribute 'manager_pkg'
[CRITICAL] Rendering SLS 'base:tomcat.manager' failed: Jinja variable 'dict object' has no attribute 'manager_pkg'
local:
    Data failed to compile:
----------
    Rendering SLS 'base:tomcat.config' failed: Jinja variable 'dict object' has no attribute 'main_config_template'
----------
    Rendering SLS 'base:tomcat.native' failed: Jinja variable 'dict object' has no attribute 'native_pkg'
----------
    Rendering SLS 'base:tomcat.manager' failed: Jinja variable 'dict object' has no attribute 'manager_pkg'

[noelmcloughlin]

See saltstack-formulas/postgres-formula/pull/164 for reference solution.

[noelmcloughlin]

Port exists.

$ brew install tomcat
==> Downloading https://www.apache.org/dyn/closer.cgi?path=tomcat/tomcat-8/v8.5.21/bin/apache-tomcat-8.5.21.tar.gz
==> Best Mirror http://mirrors.whoishostingthis.com/apache/tomcat/tomcat-8/v8.5.21/bin/apache-tomcat-8.5.21.tar.gz
######################################################################## 100.0%
==> Caveats
To have launchd start tomcat now and restart at login:
  brew services start tomcat
Or, if you don't want/need a background service you can just run:
  catalina run
==> Summary
🍺  /usr/local/Cellar/tomcat/8.5.21: 632 files, 12.8MB, built in 39 seconds

$ brew link tomcat
Warning: Already linked: /usr/local/Cellar/tomcat/8.5.21
To relink: brew unlink tomcat && brew link tomcat

[noelmcloughlin]

Refer to saltstack-formulas/postgres-formula/issues/162

[noelmcloughlin]

I got tomcat working on Darwin: tomcat_on_Darwin_verified (1).txt

[noelmcloughlin]

Just after salt-formula completes launchd keeps retrying tomcat startup as uid 0. Thankfully this fails and launchd gives up (Address already in use). So Tomcat is running as unprivileged user.

This means formula works for Darwin. Tested reboot and launchd starts tomcat as un-privledged user as expected (LaunchAgents start with permissions of currently logged users).

[noelmcloughlin]

Preparing one PR for each tomcat.state and one PR for pillar/os/defaults.

[noelmcloughlin]

Requires Homebrew (https://brew.sh/) and (maybe) Homebrew services (https://github.com/Homebrew/homebrew-services)

[noelmcloughlin]

I have some ideas why Salt/Launchd spawns two process starts during salt-formula execution on MacOS/Darwin. It might be related decision to integrate with /Library/LaunchAgents/ and we have two sessions (privileged sudo, unprivileged logged on user) open on Darwin so launchd decides both sessions need Tomcat started. To figure this out is another days work ;-)

[noelmcloughlin]

MacOS support was introduced & merged by #71, #72, #73, #74, #75, #76.
Improvement needed: #77