Skip to content

Env must be list, not dict, in defaults.yml #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2018
Merged

Env must be list, not dict, in defaults.yml #183

merged 1 commit into from
Jan 23, 2018

Conversation

noelmcloughlin
Copy link
Contributor

Use 'env: []' (list) not 'env: {}' (dict) in defaults.yaml.

(Replaces/rebases #180).

@noelmcloughlin noelmcloughlin mentioned this pull request Jan 22, 2018
Closed
vutny
vutny approved these changes Jan 23, 2018
View reviewed changes
Copy link
Contributor

@vutny vutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noelmcloughlin noelmcloughlin merged commit 15898f6 into master Jan 23, 2018
@noelmcloughlin
Copy link
Contributor Author

Thanks @vutny

@noelmcloughlin noelmcloughlin deleted the ListNotDict branch January 23, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vutny vutny vutny approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noelmcloughlin @vutny