Skip to content

Support upstream repo for Fedora 25, 24, and 23 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2017
Merged

Support upstream repo for Fedora 25, 24, and 23 #144

merged 1 commit into from
Feb 5, 2017

Conversation

YetAnotherMinion
Copy link
Contributor

@YetAnotherMinion YetAnotherMinion commented Feb 5, 2017

Resolves #143
Add a macro to override base_url for upstream package url using the grain oscodename

Now supports Fedora 25, 24, 23

Resolves #143
Add a macro to override base_url for upstream package url using the grain  from 3 most recent Fedora distributions
@myoung34
Copy link

myoung34 commented Feb 5, 2017

LGTM. did it work as expected for you? I dont spot anything

@YetAnotherMinion
Copy link
Contributor Author

YetAnotherMinion commented Feb 5, 2017

I had to make the change to get the package repository to work. The current patch is working on my servers. Caveat: Only tested on Fedora 25

Side note: Now I am trying to get the client library states to work. It looks like the YUM repo for Fedora does not have postgresql96-client packages. The way I am reading the installation page is that all the programs that the "client" package would install on other distros are just rolled into the vanilla postgresql96 package on Fedora.

Edit: specifying the pkg_client: 'postgresql96' works to install the entire formula on Fedora (assuming you specify the service correctly service: postgresql-9.6)

@YetAnotherMinion
Copy link
Contributor Author

YetAnotherMinion commented Feb 5, 2017 via email

@YetAnotherMinion
Copy link
Contributor Author

@vutny can you merge?

@javierbertoli javierbertoli merged commit 0942d5f into saltstack-formulas:master Feb 5, 2017
@javierbertoli
Copy link
Member

Thanks @YetAnotherMinion !

@YetAnotherMinion YetAnotherMinion deleted the fedora_support branch February 8, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants