Skip to content

Conversation

btrn11
Copy link
Collaborator

@btrn11 btrn11 commented Oct 7, 2025

@W-19830917@

What does this PR do?

What issues does this PR fix or reference?

  • Text fixes
  • Display correct version name in bundle version report
  • Change required target-dev-hub to dev-hub-org for bundle install
  • Remove colon in sf package bundle install report messages
  • Output bundle version id instead of bundle id for bundle version create
  • Bubble up error when bundle version is created twice with same config
  • Fix polling issue, version creation spinner not starting

@btrn11 btrn11 requested a review from a team as a code owner October 7, 2025 19:01
Copy link
Contributor

@jshackell-sfdc jshackell-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my small edits.

@btrn11 btrn11 changed the title @W-19830917@ fix: fix bundle cli issues dev preview @W-19830917@ fix: fix bundle cli issues dev preview (plugin-packaging) Oct 7, 2025
btrn11 and others added 2 commits October 7, 2025 15:24
@btrn11
Copy link
Collaborator Author

btrn11 commented Oct 9, 2025

image

@btrn11
Copy link
Collaborator Author

btrn11 commented Oct 9, 2025

image

@btrn11
Copy link
Collaborator Author

btrn11 commented Oct 9, 2025

image

@btrn11
Copy link
Collaborator Author

btrn11 commented Oct 9, 2025

image

@btrn11 btrn11 requested a review from WillieRuemmele October 10, 2025 15:53
],
"flagAliases": ["apiversion", "targetusername", "u"],
"flagChars": ["b", "d", "o", "w"],
"flags": ["api-version", "bundle", "dev-hub-org", "flags-dir", "json", "loglevel", "target-org", "verbose", "wait"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the target-dev-hub org flag changed to dev-hub-org which is a breaking change, and 3 month warning before changing is required

flags['package-install-request-id'],
flags['target-org'].getConnection(flags['api-version'])
);
this.display(result, flags.verbose);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does --verbose do now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need verbose here for now

@WillieRuemmele WillieRuemmele merged commit 2bc82f2 into main Oct 10, 2025
13 checks passed
@WillieRuemmele WillieRuemmele deleted the btrn11/fix-bundle-dev-preview branch October 10, 2025 17:15
@WillieRuemmele WillieRuemmele restored the btrn11/fix-bundle-dev-preview branch October 10, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants