fix(telemetry): always set isError for tool events W-19760313
#308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a default value for
isErrorin when capturing theTOOL_CALLEDtelemetry event.mcp spec:
https://modelcontextprotocol.io/specification/2025-06-18/schema#calltoolresult
The WI mentions changing the
CallToolResulttype to markisErrorrequired but since we only want this for telemetry it's easier to handle it here (also avoid overriding a type from the SDK and tools can still omit it for successful scenarios)What issues does this PR fix or reference?
@W-19760313@