Add --sandbox-only flag to force check of allowed orgs to ensure they are only Sandboxes. #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix apex tests tool name in readme for mcp json example.
zerkz
commented
Oct 7, 2025
zerkz
commented
Oct 7, 2025
| const productionOrgs: string[] = []; | ||
|
|
||
| // eslint-disable-next-line no-await-in-loop | ||
| for (const org of allowedOrgs) { |
There was a problem hiding this comment.
We could possibly speed up this section/logic by putting this unit of work into it's own promise, tossing it in an array, and doing Promise.all(). Might get rid of the need for all these eslint disables!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
--sandbox-onlyflag that does checks on server start, via SOQL queries the fieldOrganization.IsSandboxfor each allowed org. If any of these orgs returnfalsefor IsSandbox, we abort the server start/throw an error.This gives users the ability opt in for an extra layer of security/safety.
The decision to check only at server start is a mixture of not slowing down everything (by checking before every org interaction/tool command), and the unlikely prospect of a developer re-authing a production org over the same alias post-server start. It's a tradeoff that I think makes sense.
What issues does this PR fix or reference?
https://github.com/salesforcecli/mcp/discussions/122
unit tests included and tested against my developer edition org.