Skip to content

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Oct 14, 2022

Also adds an altnames attribute (comma-separated) and allows trac to be a comma-separated list @kwankyu

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 15, 2022

I didn't test, but you may need

--- a/scripts/geocode.py
+++ b/scripts/geocode.py
@@ -157,6 +157,7 @@ def writeToDevmap():
             tracQuery += f"&or&author=~{name}"
             tracQuery += f"&or&reviewer=~{name}"
         tracQuery += "&max=500&col=id&col=summary&col=author&col=status&col=priority&col=milestone&col=reviewer&order=priority"
+        tracQuery = tracQuery.replace(" ", "%20")
         a.setAttribute("href", tracQuery)
         a.setAttribute("class", "trac")
         if main_trac:

as names contain spaces.

@mkoeppe
Copy link
Author

mkoeppe commented Oct 15, 2022

Yes, that's better, thanks.

@mkoeppe
Copy link
Author

mkoeppe commented Oct 15, 2022

(I've tested with make devmap and then opening templates/devs.html in the browser)

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Oct 15, 2022

I cannot approve this, perhaps because I don't have write access.

@mkoeppe
Copy link
Author

mkoeppe commented Oct 15, 2022

I think this is something that we need to figure out in general for the github transition - how to configure reviews, project membership, and teams

@haraldschilly haraldschilly merged commit 4803c75 into sagemath:master Oct 15, 2022
@kwankyu
Copy link
Collaborator

kwankyu commented Oct 15, 2022

Thanks, Harald!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants