-
-
Notifications
You must be signed in to change notification settings - Fork 179
Merged trac list #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged trac list #311
Conversation
I am not sure the best way to review this. I read through the changes up to the end of the C's, and only noticed two things: |
This is not "ready for review". Rather this needs work and needs comments. (1a) Many duplicates can be obviously merged. The problem here is that there are too many. (1b) Other many duplicates have conflicting information. The problem here is that I don't know how to deal with them. (2) Checking one by one for contributions would take too much time. Frankly I doubt if this task is worth that much time. |
I think we do not necessarily have to make it perfect in this one PR. |
Regarding the item 1 in https://groups.google.com/g/sage-devel/c/1T2dm4gV2Z0, that is,
the changelog data is the accumulated list of contributors to sage up to now. Right? Does this include the contributors in the Mercurial days? |
One thing that may be easy to do if you have the tools to do this is to address the sorting order.
I think so, but I can't be sure that it's complete. |
The merged list is already sorted by the last name. Do you mean something else?
We may assume that it is practically complete as there is no other source.
Thanks. We may use the changelog list to delete names with no contribution from the merged list. |
Conversely, perhaps, names in the changelog list missing in the merged list are silent contributors who didn't bother to add their names to the public lists (website and trac). I may add just the names, with no other info, to the merged list. Do you agree or disagree? |
-1 from me. |
Sorry, I forgot to add more specifics. With your PR, the sorting order has changed for names with diacritics. For example, "Châtel" now sorts after "Chr..." |
Sounds like a good plan |
I agree.
I can remove (some of) easy duplicates manually. Do we have deadline (when to merge this PR)? |
No deadline, but it will be easier for others to send PRs to update data when this is already merged |
Hmm. Let me see if there is a better sorting tool for xml data to address that issue. |
I see. Let me have a week to remove duplicates as many as I can. Then I will leave it to others to update further. |
"Names with no contribution" means names in the merged list that does not appear in the changelog list and there are no entries in the search results in trac by the last name and trac or github account names. |
I removed all obvious duplicates (but of course may have missed some). Other duplicates need an update from the individual. Now ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this work!
Thanks!
"Martin Albrecht" is a missed obvious duplicate, obviously :) |
For record, these are the names with no contribution, removed from the merged list:
|
Hi, I'm merging this and fixing any obvious issues, if there is any. |
I'll merge this now. Just to let you know, duplicate attributes are a problem, i.e.
Removing the 2nd one, which is older. While geocoding the locations, I found an erroneous entry Once I'm through this I'll point you to my patch. |
Thanks. This seems my mistake.
My tools were not smart enough. I did not attempt to fix these errors.
Thank you! |
Looks good to me. Thanks for checking locations. I know it's a lot of work. |
I doubt if it is now safe to delete (as announced) https://trac.sagemath.org/#AccountNamesMappedtoRealNamestobemovedtoSagedevelopermap since https://www.sagemath.org/development-map.html does not show trac account names mapping to real names, which is the primary purpose of the former page. We did not yet migrate to github. |
#313 attempts to solve this |
I did the merge with the developer list at trac, as requested
https://groups.google.com/g/sage-devel/c/1T2dm4gV2Z0
(1) There are many duplicates. I removed some, but soon gave up.
(2) I didn't check if a person really has contributions to sage (trac ticket).