Skip to content

Merged trac list #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Merged trac list #311

merged 4 commits into from
Oct 14, 2022

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Oct 11, 2022

I did the merge with the developer list at trac, as requested

https://groups.google.com/g/sage-devel/c/1T2dm4gV2Z0

(1) There are many duplicates. I removed some, but soon gave up.

(2) I didn't check if a person really has contributions to sage (trac ticket).

@JohnCremona
Copy link
Member

I am not sure the best way to review this. I read through the changes up to the end of the C's, and only noticed two things:
1. Luis Felipe Tabera Alonso is duplicated
2. Jenny Cooley left Warwick several years ago and had not contributed since, I do not know of a current address.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 11, 2022

I am not sure the best way to review this.

This is not "ready for review". Rather this needs work and needs comments.

(1a) Many duplicates can be obviously merged. The problem here is that there are too many.

(1b) Other many duplicates have conflicting information. The problem here is that I don't know how to deal with them.

(2) Checking one by one for contributions would take too much time. Frankly I doubt if this task is worth that much time.

@mkoeppe
Copy link

mkoeppe commented Oct 11, 2022

I think we do not necessarily have to make it perfect in this one PR.
After all, the duplication / inconsistency was already present before -- just spread over two of our web pages. It is already a great improvement to merge it into one place.
Merging duplicates, verifying/updating information could be done in follow-up PRs.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

Regarding the item 1 in https://groups.google.com/g/sage-devel/c/1T2dm4gV2Z0, that is,

  1. Merge info from ​https://github.com/sagemath/sage-changelogs/blob/master/merger/contributors/9.7 into ​https://github.com/sagemath/website/blob/master/conf/contributors.xml

the changelog data is the accumulated list of contributors to sage up to now. Right? Does this include the contributors in the Mercurial days?

@mkoeppe
Copy link

mkoeppe commented Oct 12, 2022

One thing that may be easy to do if you have the tools to do this is to address the sorting order.

the changelog data is the accumulated list of contributors to sage up to now. Right? Does this include the contributors in the Mercurial days?

I think so, but I can't be sure that it's complete.
Comparing https://www.sagemath.org/changelogs/sage-5.2.txt (54 contributors) and https://github.com/sagemath/sage-changelogs/blob/master/merger/contributors/5.2 (637 lines)
it's clear that at least an attempt was made back then to collect the contributors info from the previous releases

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

One thing that may be easy to do if you have the tools to do this is to address the sorting order.

The merged list is already sorted by the last name. Do you mean something else?

the changelog data is the accumulated list of contributors to sage up to now. Right? Does this include the contributors in the Mercurial days?

I think so, but I can't be sure that it's complete.

We may assume that it is practically complete as there is no other source.

Comparing https://www.sagemath.org/changelogs/sage-5.2.txt (54 contributors) and https://github.com/sagemath/sage-changelogs/blob/master/merger/contributors/5.2 (637 lines) it's clear that at least an attempt was made back then to collect the contributors info from the previous releases

Thanks. We may use the changelog list to delete names with no contribution from the merged list.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

Conversely, perhaps, names in the changelog list missing in the merged list are silent contributors who didn't bother to add their names to the public lists (website and trac).

I may add just the names, with no other info, to the merged list. Do you agree or disagree?

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

I may add just the names, with no other info, to the merged list. Do you agree or disagree?

-1 from me.

@mkoeppe
Copy link

mkoeppe commented Oct 12, 2022

One thing that may be easy to do if you have the tools to do this is to address the sorting order.

The merged list is already sorted by the last name. Do you mean something else?

Sorry, I forgot to add more specifics. With your PR, the sorting order has changed for names with diacritics. For example, "Châtel" now sorts after "Chr..."

@mkoeppe
Copy link

mkoeppe commented Oct 12, 2022

We may use the changelog list to delete names with no contribution from the merged list.

Sounds like a good plan

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

I think we do not necessarily have to make it perfect in this one PR. After all, the duplication / inconsistency was already present before -- just spread over two of our web pages. It is already a great improvement to merge it into one place.

I agree.

Merging duplicates, verifying/updating information could be done in follow-up PRs.

I can remove (some of) easy duplicates manually. Do we have deadline (when to merge this PR)?

@mkoeppe
Copy link

mkoeppe commented Oct 12, 2022

No deadline, but it will be easier for others to send PRs to update data when this is already merged

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

With your PR, the sorting order has changed for names with diacritics. For example, "Châtel" now sorts after "Chr..."

Hmm. Let me see if there is a better sorting tool for xml data to address that issue.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

No deadline, but it will be easier for others to send PRs to update data when this is already merged

I see. Let me have a week to remove duplicates as many as I can. Then I will leave it to others to update further.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 12, 2022

"Names with no contribution" means names in the merged list that does not appear in the changelog list and there are no entries in the search results in trac by the last name and trac or github account names.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 13, 2022

I removed all obvious duplicates (but of course may have missed some).

Other duplicates need an update from the individual.

Now ready to be merged.

Copy link

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this work!

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 13, 2022

Thanks!

I removed all obvious duplicates (but of course may have missed some).

"Martin Albrecht" is a missed obvious duplicate, obviously :)

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 13, 2022

For record, these are the names with no contribution, removed from the merged list:

 'Ali Abdurrazzak',
 'Carolina Benedetti',
 'Samuel Boucher',
 'Lucien Clavier',
 'Håvard Damm-Johnsen',
 'Daniel Disegni',
 'Max Flander',
 'Martin Flashman',
 'Prasanna Gautam',
 'Surya Teja Gavva',
 'Glenn R Henshaw',
 'David Horgan',
 'John Irving',
 'George Jennings',
 'Adrian C. Keister',
 'Lily Khadjavi',
 'Nathanael Komline',
 'François Lemaire',
 'Tirthankar Mazumder',
 'Razvan Alex Mezei',
 'Manu K. Mohan',
 'David Morawski',
 'M.Tip Phaovibul',
 'Daniel Pruessner',
 'Georg Regensburger',
 'Adarsh Saraf',
 'Sam Schiavone',
 'Alexandre Sedoglavic',
 'Patricia Sorya',
 'David Swinarski',
 'Lama Tarsissi',
 'Kazuo Thow',
 'Morten Hein Tiljeset',
 'Gwyneth Whieldon',
 'Albert Yiamakis',
 'Wang Zihan'

@haraldschilly
Copy link
Member

Hi, I'm merging this and fixing any obvious issues, if there is any.

@haraldschilly haraldschilly merged commit b13daf9 into sagemath:master Oct 14, 2022
@haraldschilly
Copy link
Member

I'll merge this now. Just to let you know, duplicate attributes are a problem, i.e.

 location="Universidad de la República, Uruguay"
 location="Montevideo, Uruguay"

Removing the 2nd one, which is older.


While geocoding the locations, I found an erroneous entry location="amitabh009 at gmail dot com" → removing this. Also, just "INRIA" is not specific enough to get a location. same for "Bloomberg", … and some other entries like that.

Once I'm through this I'll point you to my patch.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 14, 2022

I'll merge this now. Just to let you know, duplicate attributes are a problem, i.e.

 location="Universidad de la República, Uruguay"
 location="Montevideo, Uruguay"

Removing the 2nd one, which is older.

Thanks. This seems my mistake.

While geocoding the locations, I found an erroneous entry location="amitabh009 at gmail dot com" → removing this. Also, just "INRIA" is not specific enough to get a location. same for "Bloomberg", … and some other entries like that.

My tools were not smart enough. I did not attempt to fix these errors.

Once I'm through this I'll point you to my patch.

Thank you!

@kwankyu kwankyu deleted the merge-trac branch October 14, 2022 11:35
@haraldschilly
Copy link
Member

@kwankyu ok, I made this b0acfa1

e.g. william stein was a duplicate, I removed some locations (some where email addresses), and stuff like that. So, from now on we tweak this file, to avoid reverting these fixes.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 14, 2022

Looks good to me. Thanks for checking locations. I know it's a lot of work.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Oct 14, 2022

I doubt if it is now safe to delete (as announced)

https://trac.sagemath.org/#AccountNamesMappedtoRealNamestobemovedtoSagedevelopermap

since

https://www.sagemath.org/development-map.html

does not show trac account names mapping to real names, which is the primary purpose of the former page. We did not yet migrate to github.

@mkoeppe
Copy link

mkoeppe commented Oct 14, 2022

I doubt if it is now safe to delete (as announced)

https://trac.sagemath.org/#AccountNamesMappedtoRealNamestobemovedtoSagedevelopermap

since

https://www.sagemath.org/development-map.html

does not show trac account names mapping to real names, which is the primary purpose of the former page. We did not yet migrate to github.

#313 attempts to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants