-
-
Notifications
You must be signed in to change notification settings - Fork 697
fix an error in macos ci #40788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix an error in macos ci #40788
Conversation
Uninstall cmake before installing dependencies.
|
And you can see this issue actions/runner-images#12912 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a macOS CI error by adding a command to uninstall cmake before installing dependencies. The change addresses a specific CI failure where conflicting cmake installations were causing build issues.
- Adds a forced uninstall of cmake before dependency installation in the macOS CI workflow
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tobiasdiez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Could you please add a short comment linking the above gh issue? Feel free to set to positive review after the CI is green.
|
Documentation preview for this PR (built with commit 244d0e1; changes) is ready! 🎉 |
|
https://github.com/sagemath/sage/actions/runs/17540857013/job/49812147119#annotation:6:59806 |
|
Okay, but it's failing at a later point - so this is already a nice improvement. For reference: https://github.com/sagemath/sage/actions/runs/17540857013/job/49812147119#step:6:59711 |
.github/workflows/ci-macos.yml
Outdated
| - name: Build | ||
| run: | | ||
| source ./.homebrew-build-env | ||
| export CXXFLAGS="-DNTL_THREADS=0 -fno-threadsafe-statics $CXXFLAGS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really needed, or was this a result of you trying to fix the build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I want to fix it, but it seems useless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, then I would propose you remove this change here again, add a short comment to actions/runner-images#12912 and then we merge this, leaving the real build errors for another PR.
The root cause has been fixed now. Can you test it? @tobiasdiez |
Uninstall cmake before installing dependencies. fix an error in https://github.com/sagemath/sage/actions/runs/17527169455/job/49779204903
📝 Checklist
⌛ Dependencies
actions/runner-images#12912