-
-
Notifications
You must be signed in to change notification settings - Fork 703
Add subsection Documentation Previews to developer guide #40681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a7c16e to
2651203
Compare
|
Documentation preview for this PR (built with commit 1129d51; changes) is ready! 🎉 |
075eff0 to
9669abc
Compare
Collaborator
Author
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 16, 2025
sagemathgh-40681: Add subsection Documentation Previews to developer guide <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> as promised in sagemath#40586 (comment) The added text highlights features of the documentation previews broken as of 10.8.beta2: - PDF icons should not appear in the HTML documentation previews for PRs. - TESTS blocks should appear in the HTML documentation previews for PRs. - "Sage" "Python" "Sage Live" tabs should appear in the full live documentation for releases (perhaps side effects of the "missing sagemath kernel" issue sagemath#40586 (comment)). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40681 Reported by: Kwankyu Lee Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as promised in #40586 (comment)
The added text highlights features of the documentation previews broken as of 10.8.beta2:
📝 Checklist
⌛ Dependencies