-
-
Notifications
You must be signed in to change notification settings - Fork 704
Fix documentation for Drinfeld modules #40599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
actually the command should be used as |
|
Oh sure, sorry! |
|
Documentation preview for this PR (built with commit 3a1fda2; changes) is ready! 🎉 |
|
Thanks for the ping. First failure: Second one: Doc build: I manually went through all instances of |
|
normally I'd want to check the documentation changes by looking at the generated HTML, but because of the dependencies, there are a lot of false positives. Combined with the fact that the HTML is slow to load and the PDF build is currently broken, I was thinking of looking at the HTML diff after the dependency is merged. (the problem is incorrect rendering, not build failure.) |
Co-authored-by: user202729 <[email protected]>
|
two more bugs I found (although not introduced by this PR). I'd positive review afterwards. diff --git a/src/sage/rings/function_field/drinfeld_modules/action.py b/src/sage/rings/function_field/drinfeld_modules/action.py
index 4962162424e..35408b09326 100644
--- a/src/sage/rings/function_field/drinfeld_modules/action.py
+++ b/src/sage/rings/function_field/drinfeld_modules/action.py
@@ -42,12 +42,12 @@ class DrinfeldModuleAction(Action):
.. NOTE::
The user should never explicitly instantiate the class
- `DrinfeldModuleAction`.
+ :class:`DrinfeldModuleAction`.
.. WARNING::
- This class may be replaced later on. See issues #34833 and
- #34834.
+ This class may be replaced later on. See :issue:`34833` and
+ :issue:`34834`.
INPUT: the Drinfeld module
diff --git a/src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py b/src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
index 594f8645ae1..02d0e998bde 100644
--- a/src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
+++ b/src/sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module.py
@@ -486,7 +486,7 @@ class DrinfeldModule_rational(DrinfeldModule_charzero):
sage: phi.coefficient_in_function_ring(2)
T^2
- Compare with the method meth:`coefficient`::
+ Compare with the method :meth:`coefficient`::
sage: phi.coefficient(2)
U^2 |
|
Thanks very much for the fixes! |

We fix a couple of issues in the documentation of Drinfeld modules and replace everywhere
\mathbb{F}by\GF.📝 Checklist
⌛ Dependencies
#40430