Richcmp for pseudomorphisms #39837
Merged
Richcmp for pseudomorphisms #39837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
reviewed
Mar 31, 2025
user202729
reviewed
Mar 31, 2025
|
Documentation preview for this PR (built with commit c888597; changes) is ready! 🎉 |
user202729
reviewed
Mar 31, 2025
Contributor
|
If tests pass, this should be good for me. |
Contributor
|
Also do edit the first post to say exactly " Fixes #39807 " , if you did it correctly the "successfully merging this pull request may close these issues" part on the right should show that issue. |
Contributor
|
Looks good, but you should rebase it on develop (be careful with the force push, see above) |
added 3 commits
April 2, 2025 06:41
Contributor
Author
|
Done. I think it's okay but please tell me if you see an issue. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 3, 2025
sagemathgh-39837: Richcmp for pseudomorphisms This PR implements rich comparison for pseudomorphisms. Fixes sagemath#39807 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39837 Reported by: Xavier Caruso Reviewer(s): user202729, Xavier Caruso
5 tasks
Contributor
|
There's a merge conflict (probably caused by the force push to |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-39837: Richcmp for pseudomorphisms This PR implements rich comparison for pseudomorphisms. Fixes sagemath#39807 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39837 Reported by: Xavier Caruso Reviewer(s): user202729, Xavier Caruso
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements rich comparison for pseudomorphisms.
Fixes #39807
📝 Checklist