Skip to content

Conversation

@user202729
Copy link
Contributor

@user202729 user202729 commented Jan 1, 2025

As in the title. Temporary workaround.

I guess the current method is rather suboptimal (first numpy 1.26 and fpylll is downloaded, then it is discarded), but better than it not being tested.
A better way may be to generate separate yml files.

Let's see if it works.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@user202729 user202729 marked this pull request as draft January 1, 2025 15:40
@user202729
Copy link
Contributor Author

user202729 commented Jan 1, 2025

this particular job has the numpy 2 test at https://github.com/sagemath/sage/actions/runs/12572088860/job/35043683578?pr=39241

Testing locally there's a bunch of failing tests because of e.g. #39242

sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/modules/free_module_integer.py  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/doctest/forker.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/plot/multigraphics.py  # 2 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/sageinspect.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/graphs/generic_graph.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/cachefunc.pyx  # 38 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/cython.py  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/groups/perm_gps/permgroup.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/plot/streamline_plot.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/topology/simplicial_complex_examples.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/doc/en/thematic_tutorials/group_theory.rst  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/groups/finitely_presented_named.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/groups/libgap_wrapper.pyx  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/schemes/elliptic_curves/period_lattice_region.pyx  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/topology/simplicial_complex.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/plot/arrow.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/groups/perm_gps/permgroup_morphism.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/rings/integer.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/combinat/designs/incidence_structures.py  # Timed out
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/env.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/structure/element.pyx  # 35 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/graphs/connectivity.pyx  # 2 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/combinat/fully_packed_loop.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/functions/special.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/symbolic/ring.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/rings/real_mpfi.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/structure/coerce.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/doc/en/prep/Quickstarts/Statistics-and-Distributions.rst  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/numerical/optimize.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/rings/polynomial/ore_polynomial_element.pyx  # 6 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/symbolic/function.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/rings/tate_algebra_ideal.pyx  # 6 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/doctest/sources.py  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/stats/basic_stats.py  # 2 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/dev_tools.py  # 6 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/arith/long.pxd  # 34 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/graphs/graph_decompositions/fast_digraph.pyx  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/lazy_attribute.pyx  # 3 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/inherit_comparison.pyx  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/cpython/cython_metaclass.pyx  # 4 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/rings/integer_fake.pxd  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/cpython/wrapperdescr.pxd  # 6 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/doc/en/thematic_tutorials/numerical_sage/numpy.rst  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/cpython/string.pyx  # 1 doctest failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/misc/package_dir.py  # 5 doctests failed
sage -t --warn-long 5.0 --random-seed=214579564014707247175626551657098621007 src/sage/symbolic/pynac.pxi  # 1 doctest failed

some of them are fpylll issue it seems.

@github-actions
Copy link

github-actions bot commented Jan 1, 2025

Documentation preview for this PR (built with commit fa86219; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor

See also #39267 for the updated env files.

@user202729
Copy link
Contributor Author

I guess this PR wouldn't be necessary when numpy 2 is supported by official conda anyway. Just a test.

@tobiasdiez
Copy link
Contributor

I guess this PR wouldn't be necessary when numpy 2 is supported by official conda anyway. Just a test.

It's a great way to test the changes that are necessary for numpy 2 support. Speaking of, could you please create a new PR for the fix to flint? Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 7, 2025
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.

URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 9, 2025
sagemathgh-39291: Workaround to allow flint to be compiled with numpy 2
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 10, 2025
sagemathgh-39291: Workaround to allow flint to be compiled with numpy 2
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 12, 2025
sagemathgh-39291: Workaround to allow flint to be compiled with numpy 2
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 16, 2025
sagemathgh-39291: Workaround to allow flint to be compiled with numpy 2
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 17, 2025
sagemathgh-39291: Workaround to allow flint to be compiled with numpy 2
    
As discussed in sagemath#39241 .

Based on mkoeppe@6247975f786c85c35124a66a
0d32df00260461c5 , but also change the template file.

Note that for tests to pass, sagemath#39242
is also needed.
    
URL: sagemath#39291
Reported by: user202729
Reviewer(s): Tobias Diez
@user202729 user202729 closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants