-
-
Couldn't load subscription status.
- Fork 681
Adding a tikz method to FinitePoset class #38848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation preview for this PR (built with commit 4518878; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo two small code formatting things. Once changed, you can set a positive review.
Co-authored-by: Travis Scrimshaw <[email protected]>
|
J'ai essayé (dans une ubuntu 24.04 standard) et ca marche pas: |
|
after installing |
|
The previous issues may be due to complicated nature of elements in the example I tried. With simpler elements, this gives the usual ugly picture, despite graphviz and dot2tex being installed in ubuntu itself. |
|
Thanks for fixing the
Long time ago, when docker was still working on gitlab, I needed to add the line |
The Maybe one solution is to double the doctest once with tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, allons-y
|
Notes: I first had to do "make dot2tex" No visible difference with the vusual |
sagemathgh-38848: Adding a tikz method to FinitePoset class We add a `tikz` method to the class `FinitePoset` returning a `TikzPicture` instance from `sage.misc.latex_standalone` module. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies It uses the tikz method for graphs added in sagemath#38798 and the follow-up small fix made in sagemath#38847. URL: sagemath#38848 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
sagemathgh-38848: Adding a tikz method to FinitePoset class We add a `tikz` method to the class `FinitePoset` returning a `TikzPicture` instance from `sage.misc.latex_standalone` module. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies It uses the tikz method for graphs added in sagemath#38798 and the follow-up small fix made in sagemath#38847. URL: sagemath#38848 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
We add a
tikzmethod to the classFinitePosetreturning aTikzPictureinstance fromsage.misc.latex_standalonemodule.📝 Checklist
⌛ Dependencies
It uses the tikz method for graphs added in #38798 and the follow-up small fix made in #38847.