Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions build/pkgs/ecm/checksums.ini
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tarball=ecm-VERSION.tar.gz
sha1=f35d225d1d44f9b8ad420bf9b50a92582f681337
sha256=c721dd22e557c4a5dac9ac7e156a400cd2298812dd1f9b56e89966de01471ba8
upstream_url=https://gitlab.inria.fr/zimmerma/ecm/uploads/89f6f0d65d3e980cef33dc922004e4b2/ecm-VERSION.tar.gz
sha1=257e1c327cd6de1097b7036c7ec358fe3dbfa4ad
sha256=7d20ece61ab6a20ad85f2c18064cabd77dc46a96ff894b5220dbb16e4666e8a5
upstream_url=https://gitlab.inria.fr/zimmerma/ecm/uploads/ad3e5019fef98819ceae58b78f4cce93/ecm-VERSION.tar.gz
2 changes: 1 addition & 1 deletion build/pkgs/ecm/package-version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.0.5
7.0.6
1 change: 0 additions & 1 deletion src/sage/interfaces/ecm.py
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,6 @@ def _find_factor(self, n, factor_digits, B1, **kwds):
"""
n = self._validate(n)
kwds.setdefault('c', 1000000000)
kwds.setdefault('I', 1)
if factor_digits is not None:
B1 = self.recommended_B1(factor_digits)
kwds['one'] = True
Expand Down
10 changes: 6 additions & 4 deletions src/sage/libs/libecm.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,13 @@ def ecmfactor(number, double B1, verbose=False, sigma=0):
Some special cases::

sage: ecmfactor(1, 100)
(True, 1, ...)
Traceback (most recent call last):
...
ValueError: Input number (1) must be greater than 1
sage: ecmfactor(0, 100)
Traceback (most recent call last):
...
ValueError: Input number (0) must be positive
ValueError: Input number (0) must be greater than 1
"""
cdef mpz_t n, f
cdef int res
Expand All @@ -165,8 +167,8 @@ def ecmfactor(number, double B1, verbose=False, sigma=0):
sage_int_number = Integer(number)
sage_int_sigma = Integer(sigma)

if number <= 0:
raise ValueError("Input number (%s) must be positive"%number)
if number <= 1:
raise ValueError("Input number (%s) must be greater than 1"%number)

if verbose:
print("Performing one curve with B1=%1.0f" % B1)
Expand Down