Skip to content

Fix segfault for Weil polynomials #37861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 3 commits into from
May 12, 2024
Merged

Fix segfault for Weil polynomials #37861

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b683f2
Fix segfault for Weil polynomials
kedlaya Apr 24, 2024
959bf37
Add doctest
kedlaya Apr 24, 2024
95d8bea
Fix a second segfault when degree < 0
kedlaya Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/sage/rings/polynomial/weil/weil_polynomials.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ class WeilPolynomials_iter():
if node_limit is None:
node_limit = -1
force_squarefree = Integer(squarefree)
self.process = dfs_manager(d2, q, coefflist, modlist, coeffsign,
self.process = None if d2<0 else dfs_manager(d2, q, coefflist, modlist, coeffsign,
num_cofactor, node_limit, parallel,
force_squarefree)
self.q = q
Expand Down Expand Up @@ -537,7 +537,12 @@ class WeilPolynomials():
sage: list(WeilPolynomials(10, 2, lead=(1,-3,5,-5,5,-5)))
[x^10 - 3*x^9 + 5*x^8 - 5*x^7 + 5*x^6 - 5*x^5 + 10*x^4 - 20*x^3 + 40*x^2 - 48*x + 32]

Test that :issue:`37860` is resolved::

sage: list(WeilPolynomials(-1, 1))
[]
sage: list(WeilPolynomials(0, 1, sign=-1))
[]
"""
def __init__(self, d, q, sign=1, lead=1, node_limit=None, parallel=False, squarefree=False, polring=None):
r"""
Expand Down