`build/pkgs/pytest*`: Change to standard wheel packages #37301

mkoeppe · 2024-02-12T03:09:25Z

Vote: https://groups.google.com/g/sage-devel/c/MIU-xo9b7pc
Vote (redo): https://groups.google.com/g/sage-devel/c/lPLoA7zaoyg

Fixes #31110

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

mkoeppe · 2024-02-18T18:24:47Z

@dimpase May I suggest that you take the time to try out this PR? If you want to understand how a "wheel" package (https://deploy-livedoc--sagemath.netlify.app/html/en/developer/packaging#package-source-types) is installed, maybe install using ./sage -i -s pytest and look at what's happening in venv/var/tmp/sage

dimpase · 2024-02-18T19:25:06Z

As I said, I object to endless proliferation of more and more python (wheel - in case of pure python - or source, doesn't really matter) packages in Sage. If these were pip packages it would be possible to avoid bringing 2 more dependencies into Sage

mkoeppe · 2024-02-18T19:40:41Z

As I said, I object

We already know that.

My suggestion above is friendly guidance to a level on which a discussion makes more sense than what's currently happening in https://groups.google.com/g/sage-devel/c/5kmxaw105lg

github-actions · 2024-04-01T10:11:58Z

Documentation preview for this PR (built with commit 52840e0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu

This looks good to me. Adding two more dependencies for improving testing infrastructure of sage is not a big deal.

kwankyu · 2024-07-18T01:50:27Z

I got this:

$ sage -t --warn-long 74.7 --random-seed=64827865514850998397057649755024697710 src/sage/databases/findstat.py
Running doctests with ID 2024-07-18-10-48-42-56771071.
Running with SAGE_LOCAL='/Users/kwankyu/GitHub/sage-dev/local' and SAGE_VENV='/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9'
Using --optional=homebrew,pip,sage,sage_spkg
Features to be detected: 4ti2,SAGE_SRC,benzene,bliss,buckygen,conway_polynomials,coxeter3,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_ellcurves,database_graphs,database_jones_numfield,database_knotinfo,dvipng,ecm,fpylll,fricas,gap_package_atlasrep,gap_package_design,gap_package_grape,gap_package_guava,gap_package_hap,gap_package_polycyclic,gap_package_qpa,gap_package_quagroup,gfan,graphviz,imagemagick,ipython,jmol,jupymake,kenzo,latte_int,lrcalc_python,lrslib,matroid_database,mcqd,meataxe,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pynormaliz,pyparsing,python_igraph,requests,rpy2,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.braiding,sage.libs.ecl,sage.libs.flint,sage.libs.gap,sage.libs.linbox,sage.libs.m4ri,sage.libs.ntl,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modular,sage.modules,sage.numerical.mip,sage.plot,sage.rings.complex_double,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.polynomial.pbori,sage.rings.real_double,sage.rings.real_mpfr,sage.sat,sage.schemes,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sirocco,sphinx,symengine_py,sympy,tdlib,threejs
Doctesting 1 file.
sage -t --warn-long 74.7 --random-seed=64827865514850998397057649755024697710 src/sage/databases/findstat.py
    [134 tests, 0.58 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.8 seconds
    cpu time: 0.6 seconds
    cumulative wall time: 0.6 seconds
Features detected for doctesting: 
Error in sys.excepthook:
Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/linecache.py", line 54, in getlines
    if getattr(mod, '__file__', None) == filename:
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/py/_vendored_packages/apipkg/__init__.py", line 203, in __getattribute__
    return getattr(getmod(), name)
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/py/_vendored_packages/apipkg/__init__.py", line 188, in getmod
    x = importobj(modpath, None)
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/py/_vendored_packages/apipkg/__init__.py", line 75, in importobj
    module = __import__(modpath, None, None, ["__doc__"])
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/pytest/__init__.py", line 7, in <module>
    from _pytest.assertion import register_assert_rewrite
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/__init__.py", line 11, in <module>
    from _pytest.assertion import rewrite
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 36, in <module>
    from _pytest.assertion import util
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/util.py", line 24, in <module>
    from _pytest.config import Config
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/config/__init__.py", line 59, in <module>
    import _pytest.hookspec
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/hookspec.py", line 302, in <module>
    @hookspec(
TypeError: __call__() got an unexpected keyword argument 'warn_on_impl_args'

Original exception was:
Traceback (most recent call last):
  File "/Users/kwankyu/GitHub/sage-dev/src/bin/sage-runtests", line 178, in <module>
    import pytest
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/pytest/__init__.py", line 7, in <module>
    from _pytest.assertion import register_assert_rewrite
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/__init__.py", line 11, in <module>
    from _pytest.assertion import rewrite
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/rewrite.py", line 36, in <module>
    from _pytest.assertion import util
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/assertion/util.py", line 24, in <module>
    from _pytest.config import Config
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/config/__init__.py", line 59, in <module>
    import _pytest.hookspec
  File "/Users/kwankyu/GitHub/sage-dev/local/var/lib/sage/venv-python3.9/lib/python3.9/site-packages/_pytest/hookspec.py", line 302, in <module>
    @hookspec(
TypeError: __call__() got an unexpected keyword argument 'warn_on_impl_args'

…cies

…ires.txt ]; then git mv install-requires.txt version_requirements.txt; fi); done

mkoeppe · 2024-07-27T20:04:13Z

TypeError: call() got an unexpected keyword argument 'warn_on_impl_args'

Confirmed

kwankyu · 2024-07-31T01:54:22Z

working well now.

kwankyu

LGTM.

mkoeppe · 2024-07-31T02:04:48Z

Thanks!

sagemathgh-37301: `build/pkgs/pytest*`: Change to standard wheel packages   Vote: https://groups.google.com/g/sage-devel/c/MIU-xo9b7pc Vote (redo): https://groups.google.com/g/sage-devel/c/lPLoA7zaoyg Fixes sagemath#31110    ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#37301 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee

github-actions bot added the v: small label May 22, 2024

vbraun force-pushed the develop branch from eba5e19 to e5f42fa Compare June 3, 2024 22:15

kwankyu approved these changes Jul 18, 2024

View reviewed changes

kwankyu added s: positive review s: needs work and removed s: needs review s: positive review labels Jul 18, 2024

Matthias Koeppe added 14 commits July 27, 2024 12:22

build/pkgs/pytest: Change to standard normal package, update dependen…

303f600

…cies

build/pkgs/iniconfig: New (pytest dep)

f3e30f5

build/pkgs/pytest_xdist: Change to normal standard package

3da1401

build/pkgs/execnet: New (pytest_xdist dep)

a373c62

build/pkgs/pytest_mock: Change to standard normal package

09a1e71

for a in build/pkgs/*; do (cd build/pkgs/zlib && if [ -r install-requ…

6a04081

…ires.txt ]; then git mv install-requires.txt version_requirements.txt; fi); done

build/pkgs/execnet: Update to 2.1.1

fbc90d7

build/pkgs/pytest: Update to 8.1.1

89a995e

build/pkgs/pytest_mock: Update to 3.14.0

472818e

build/pkgs/execnet: Fix SPKG.rst

464ab39

build/pkgs/pytest: Update to 8.2.1

5820640

build/pkgs/pytest_xdist: Update to 3.6.1

1414bca

build/pkgs/iniconfig: Fix SPKG.rst, dependencies

e600717

sage -package fix-checksum :all:

986fd0d

github-actions bot added s: needs review and removed s: needs work labels Jul 27, 2024

build/pkgs/pytest: Update to 8.3.2

ab17bb0

Matthias Koeppe added 2 commits July 27, 2024 13:05

build/pkgs/pluggy: Update to 1.5.0

9b51e65

build/pkgs/exceptiongroup: Update to 1.2.2

52840e0

github-actions bot added s: needs review and removed s: needs work labels Jul 27, 2024

kwankyu approved these changes Jul 31, 2024

View reviewed changes

kwankyu added s: positive review and removed s: needs review labels Jul 31, 2024

vbraun merged commit 9fb1a15 into sagemath:develop Aug 3, 2024

github-actions bot removed the s: positive review label Aug 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

`build/pkgs/pytest*`: Change to standard wheel packages #37301

`build/pkgs/pytest*`: Change to standard wheel packages #37301

Uh oh!

mkoeppe commented Feb 12, 2024 •

edited

Loading

Uh oh!

mkoeppe commented Feb 18, 2024

Uh oh!

dimpase commented Feb 18, 2024

Uh oh!

mkoeppe commented Feb 18, 2024

Uh oh!

github-actions bot commented Apr 1, 2024 •

edited

Loading

Uh oh!

kwankyu left a comment

Uh oh!

kwankyu commented Jul 18, 2024

Uh oh!

mkoeppe commented Jul 27, 2024

Uh oh!

kwankyu commented Jul 31, 2024

Uh oh!

kwankyu left a comment

Uh oh!

mkoeppe commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

build/pkgs/pytest*: Change to standard wheel packages #37301

build/pkgs/pytest*: Change to standard wheel packages #37301

Uh oh!

Conversation

mkoeppe commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

mkoeppe commented Feb 18, 2024

Uh oh!

dimpase commented Feb 18, 2024

Uh oh!

mkoeppe commented Feb 18, 2024

Uh oh!

github-actions bot commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwankyu left a comment

Choose a reason for hiding this comment

Uh oh!

kwankyu commented Jul 18, 2024

Uh oh!

mkoeppe commented Jul 27, 2024

Uh oh!

kwankyu commented Jul 31, 2024

Uh oh!

kwankyu left a comment

Choose a reason for hiding this comment

Uh oh!

mkoeppe commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

`build/pkgs/pytest*`: Change to standard wheel packages #37301

`build/pkgs/pytest*`: Change to standard wheel packages #37301

mkoeppe commented Feb 12, 2024 •

edited

Loading

github-actions bot commented Apr 1, 2024 •

edited

Loading