Skip to content

sage.arith: Update # needs #36057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 27, 2023
Merged

sage.arith: Update # needs #36057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
166c02f
src/sage/arith/misc.py: Fix test for non-QQ number field
mkoeppe May 13, 2023
c25c97b
More # optional
mkoeppe Jun 9, 2023
070d917
More # optional
mkoeppe Jun 12, 2023
0a167f2
More # optional
mkoeppe Jun 15, 2023
64f9d19
sage.arith: More # optional
mkoeppe Jun 16, 2023
e26517f
More # optional
mkoeppe Jun 20, 2023
a2b9202
sage.arith.misc: Import sage.rings.integer before integer_ring
mkoeppe Jun 30, 2023
8c4ac5b
./sage -fixdoctests --distribution sagemath-categories --only-tags --…
mkoeppe Jul 13, 2023
128245b
Update # needs
mkoeppe Jul 14, 2023
457e8fc
sage.arith: Update # needs
mkoeppe Jul 16, 2023
a3d6301
sage.arith: Update # needs
mkoeppe Aug 7, 2023
0e844f4
src/sage/arith: Update file-level doctest tag
mkoeppe Aug 7, 2023
565fb2b
src/sage/arith/misc.py: Doctest cosmetics, use more block tags
mkoeppe Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/sage/arith/functions.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,25 +72,25 @@ def lcm(a, b=None):

Make sure we try `\QQ` and not merely `\ZZ` (:trac:`13014`)::

sage: bool(lcm(2/5, 3/7) == lcm(SR(2/5), SR(3/7))) # optional - sage.symbolic
sage: bool(lcm(2/5, 3/7) == lcm(SR(2/5), SR(3/7))) # needs sage.symbolic
True

Make sure that the lcm of Expressions stays symbolic::

sage: parent(lcm(2, 4))
Integer Ring
sage: parent(lcm(SR(2), 4)) # optional - sage.symbolic
sage: parent(lcm(SR(2), 4)) # needs sage.symbolic
Symbolic Ring
sage: parent(lcm(2, SR(4))) # optional - sage.symbolic
sage: parent(lcm(2, SR(4))) # needs sage.symbolic
Symbolic Ring
sage: parent(lcm(SR(2), SR(4))) # optional - sage.symbolic
sage: parent(lcm(SR(2), SR(4))) # needs sage.symbolic
Symbolic Ring

Verify that objects without lcm methods but which can't be
coerced to `\ZZ` or `\QQ` raise an error::

sage: F.<x,y> = FreeMonoid(2) # optional - sage.groups
sage: lcm(x,y) # optional - sage.groups
sage: F.<x,y> = FreeMonoid(2) # needs sage.groups
sage: lcm(x,y) # needs sage.groups
Traceback (most recent call last):
...
TypeError: unable to find lcm of x and y
Expand Down
2 changes: 1 addition & 1 deletion src/sage/arith/long.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# sage.doctest: optional - sage.misc.cython
# sage.doctest: needs sage.misc.cython
r"""
Fast conversion of Python objects to C long
"""
Expand Down
Loading