Categories for extension types via __getattr___

[nthiery]

With this patch, all parents and elements can inherit code from categories, even extension types. This includes in particular
generic tests (see TestSuite(...).run()):

sage: ZZ.category()
Category of commutative rings
sage: TestSuite(ZZ).run(verbose = True)
running ._test_additive_associativity() . . . pass
running ._test_an_element() . . . pass
running ._test_associativity() . . . pass
running ._test_element_pickling() . . . pass
running ._test_not_implemented_methods() . . . pass
running ._test_one() . . . pass
running ._test_pickling() . . . pass
running ._test_prod() . . . pass
running ._test_some_elements() . . . pass
running ._test_zero() . . . pass

It is to be expected that this will catch bugs in many places in the library. To start with, see #7922, #7929, #7945, #7946

See patch description for details.

Patch also available on the sage-combinat server, with a +category guard: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch

CC: @sagetrac-sage-combinat @mwhansen @robertwb @roed314

Component: categories

Author: Nicolas M. Thiéry

Reviewer: Robert Bradshaw

Merged: sage-4.3.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7921

[nthiery]

Description changed:

--- 
+++ 
@@ -1 +1,23 @@
-With this patch, all parents and elements can inherit code from categories. This is implemented via __getattr__.
+With this patch, all parents and elements can inherit code from categories, even extension types. This includes in particular
+generic tests (see TestSuite(...).run()):
+
+```
+sage: ZZ.category()
+Category of commutative rings
+sage: TestSuite(ZZ).run(verbose = True)
+running ._test_additive_associativity() . . . pass
+running ._test_an_element() . . . pass
+running ._test_associativity() . . . pass
+running ._test_element_pickling() . . . pass
+running ._test_not_implemented_methods() . . . pass
+running ._test_one() . . . pass
+running ._test_pickling() . . . pass
+running ._test_prod() . . . pass
+running ._test_some_elements() . . . pass
+running ._test_zero() . . . pass
+```
+
+It is to be expected that this will catch bugs in many places in the library.
+
+The implementation uses `__getattr__` and has some limitations (e.g. handling of lazy attributes), though.
+

[nthiery]

comment:2

All tests seem to pass with it on 4.3; I still need to double check a couple things. It does change things in many places; so the best would be to integrate it in the early phase of 4.3.2 before it rots away.

Early feedback welcome!

[nthiery]

Description changed:

--- 
+++ 
@@ -21,3 +21,5 @@
 
 The implementation uses `__getattr__` and has some limitations (e.g. handling of lazy attributes), though.
 
+Patch on: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch
+

[nthiery]

Description changed:

--- 
+++ 
@@ -19,7 +19,7 @@
 
 It is to be expected that this will catch bugs in many places in the library.
 
-The implementation uses `__getattr__` and has some limitations (e.g. handling of lazy attributes), though.
+See patch description for details
 
-Patch on: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch
+Patch also available on: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch
 

[nthiery]

Description changed:

--- 
+++ 
@@ -17,9 +17,8 @@
 running ._test_zero() . . . pass
 ```
 
-It is to be expected that this will catch bugs in many places in the library.
+It is to be expected that this will catch bugs in many places in the library. To start with, see #7922, #7929.
 
-See patch description for details
+See patch description for details.
 
-Patch also available on: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch
-
+Patch also available on the sage-combinat server, with a +category guard: http://combinat.sagemath.org/hgwebdir.cgi/patches/file/tip/trac_7921-categories_for_extension_types-nt.patch

[nthiery]

comment:4

The patch passes all tests with sage 4.3 + sage-combinat patches merged in 4.3.1 on my machine. I'll run sage -t -long tonight and report.

[nthiery]

comment:5

Hi Robert; I improved a bit TestSuite to catch more. Should I add a second patch to this one,
or make it a separate ticket?

[nthiery]

Description changed:

--- 
+++ 
@@ -17,7 +17,7 @@
 running ._test_zero() . . . pass
 ```
 
-It is to be expected that this will catch bugs in many places in the library. To start with, see #7922, #7929.
+It is to be expected that this will catch bugs in many places in the library. To start with, see #7922, #7929, #7945, #7946
 
 See patch description for details.