abstract_methods_of_class

[nthiery]

Implement a utility abstract_methods_of_class which lists all the optional and mandatory abstract methods of the class.

CC: @sagetrac-sage-combinat

Component: misc

Keywords: abstract methods

Author: Nicolas M. Thiéry

Reviewer: Florent Hivert

Merged: sage-4.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/6809

[nthiery]

comment:1

Attachment: trac_6809_abstract_methods_of_class.patch.gz

[hivert]

New version with is_optional method

[hivert]

comment:2

Attachment: trac_6809_abstract_methods_of_class.2.patch.gz

I'm done reviewing this patch. It is good upto a small detail: the code access to a private attribute. I've added an accessor method.

I just uploaded a new version of the patch after review which add a is_optional method for better encapsulation (as suggested by former comment in the code).

Nicolas: please add a positive review when you finished reviewing my changes.

Cheers,

Florent

[hivert]

Changed reviewer from Franco Saliola? to Florent Hivert

[hivert]

comment:3

During his review of my change Nicolas spotted a missing blank line after 'EXAMPLE::'... I'm re-uploading the patch...

Cheers,

Florent

[hivert]

Added missing blank line

[hivert]

comment:4

Attachment: trac_6809_abstract_methods_of_class.3.patch.gz

After Blank line added, Nicolas allows me to put the positive review.

Only apply the last trac_6809_abstract_methods_of_class.3.patch

Florent

[mwhansen]

Merged: sage-4.2.alpha1