No new prompt when doing a ./sage -sh

[jaapspies]

We used to have:

[jaap@paix sage-3.1.1]$ ./sage -sh

Starting subshell with Sage environment variables set.
Be sure to exit when you are done and do not do anything
with other copies of Sage!

Sage subshell$ exit
exit
Exited Sage subshell.
[jaap@paix sage-3.1.1]$ 

But in sage-3.2:

[jaap@paix sage-3.2]$ ./sage -sh

Starting subshell with Sage environment variables set.
Be sure to exit when you are done and do not do anything
with other copies of Sage!

[jaap@paix sage-3.2]$ 

I've been bitten by this once more!

Jaap

Component: user interface

Author: Mariah Lenox

Reviewer: Mike Hansen

Merged: sage-4.2.1.final

Issue created by migration from https://trac.sagemath.org/ticket/4644

[sagetrac-mabshoff]

comment:1

Hi Jaap,

this one should have gone to [sage-devel] since we need to find out what the bug is. Anmd having a discussion on the ticket sucks. But:

• are you using bash as default login shell?
• please post the output from sage-sage after changing "#!/usr/bin/env bash" to "#!/usr/bin/env bash -x"

Cheers,

Michael

[jaapspies]

comment:2

Ok, sorry. We had a discussion long time ago. You said you were bitten by this many times!

Due to #4512 mhansen:
Could we at least have a PS1 that includes the current directory? I always hated it when I was on a machine where "sage -sh" didn't use my existing PS1.

We now have the trouble of finding out which shell we use!

Exited Sage subshell.
[jaap@paix sage-3.2.1.rc0]$ vi local/bin/sage-sage
[jaap@paix sage-3.2.1.rc0]$ ./sage -sh
/usr/bin/env: bash -x: No such file or directory
[jaap@paix sage-3.2.1.rc0]$ which bash
/bin/bash
[jaap@paix sage-3.2.1.rc0]$ local/bin/sage-sage
/usr/bin/env: bash -x: No such file or directory
[jaap@paix sage-3.2.1.rc0]$ 

Jaap

[jaapspies]

comment:3

Maybe we can have a PS1 that is different and includes the current directory!

I've been bitten by this "defect" once more.

Jaap

[jaapspies]

comment:4

From sage-devel:

William Stein wrote:

> The justification for the existence of "./sage -sh" is that you can
> type "exit" to get out of that subshell, and all the Sage environment
> variables are no longer defined.  Also, on some systems "./sage -sh"
> changes the prompt as a reminder (it's a bug that it doesn't do this
> on all systems).
>
+1

This is https://github.com/sagemath/sage-prod/issues/4644
I opened 6 month ago.

We have to thank Mike Hansen and Craig Citro for this :)

https://github.com/sagemath/sage-prod/issues/4512

Mike:
> Could we at least have a PS1 that includes the current directory? I always hated it when I was on a machine where "sage -sh" didn't use my existing PS1.

Craig:
> Yeah, that would be very reasonable.

Jaap

[dandrake]

comment:5

There's a suggested solution to this problem: http://groups.google.com/group/sage-devel/browse_thread/thread/384d4fe7dabb722c/

I'll upload the patch from that thread in a moment.

[dandrake]

Attachment: trac_4644.patch.gz

[mwhansen]

comment:6

I think this seems good.

Note that the patch applies to the scripts repo.