Fix installation of cryptominisat and pycryptosat

[dimpase]

pycryptosat is meant to be installed as a part of cryptominisat,
but it does not happen.

This is because it's installing the Python module in SAGE_ROOT/local/
From the log:

-- Found python interpreter, libs and header files
-- Building python interface
-- Python CFLAGS:  '-Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -ffile-prefix-map=/build/python3.9-RNBry6/python3.9-3.9.2=.  -fstack-protector-strong -Wformat -Werror=format-security  -g -fwrapv -O2   '
-- Python LDFLAGS: '-lcrypt -lpthread -ldl  -lutil -lm'
-- Python LINKFORSHARED flags: '-Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions'
-- Python module will be installed to : '/home/dimpase/work/sage/local'
-- Configuring done

See
https://groups.google.com/d/msgid/sage-release/cc134257-34d8-4c26-8719-24a994dc42dan%40googlegroups.com

./sage --pip install pycryptosat

can be used as a workaround

CC: @mkoeppe @slel @vbraun

Component: packages: optional

Keywords: cryptominisat

Author: Dima Pasechnik

Branch: cdd19b0

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33162

[dimpase]

comment:1

in cmake config of cryptominisat on sees

if(DEFINED ENV{PYCRYPTOSAT_INSTALL_PATH})
    set(PY_INSTALL_PREFIX "--prefix=$ENV{PYCRYPTOSAT_INSTALL_PATH}")
elseif(DEFINED ENV{VIRTUAL_ENV})
    set(PY_INSTALL_PREFIX "")
else()
    set(PY_INSTALL_PREFIX "--prefix=${CMAKE_INSTALL_PREFIX}")
endif()

so one can explicitly set the path for the module. But to what value?

[slel]

comment:2

See also

• Upgrade cryptominisat to 5.8.0, fix build on Cygwin #25374: Upgrade cryptominisat to fix cryptominisat build on Cygwin

[slel]

Changed keywords from none to cryptominisat

[mkoeppe]

comment:4

In principle, it would be set to ${SAGE_VENV}.
But it is not a correct solution, as explained in #25374 comment:39

[dimpase]

comment:5

Replying to @mkoeppe:

In principle, it would be set to ${SAGE_VENV}.
But it is not a correct solution, as explained in #25374 comment:39

I don't see why it's not OK. Passing PYCRYPTOSAT_INSTALL_PATH=$SAGE_VENV
would make sure the python package installs in the correct venv, while the rest goes where it should.

[mkoeppe]

comment:6

Because of our installation records in SAGE_LOCAL/var/lib/sage/installed/ and SAGE_VENV/var/lib/sage/installed.

[dimpase]

comment:7

Replying to @mkoeppe:

Because of our installation records in SAGE_LOCAL/var/lib/sage/installed/ and SAGE_VENV/var/lib/sage/installed.

can we allow Python modules in SAGE_LOCAL, too? As a temporary fix, at least.

[mkoeppe]

comment:8

no, they won't be in the load path.

[mkoeppe]

comment:9

Solution is as I said in #25374 comment:48

[dimpase]

Commit: cdd19b0