Cygwin patch for Singular

[mkoeppe]

As noted in #32001 comment:1, pynac fails on cygwin-standard. We add a patch to singular to fix this

Singular/Singular#1109 (merged)

CC: @vbraun @dimpase @slel

Component: packages: standard

Author: Matthias Koeppe

Branch/Commit: d4156f7

Reviewer: Dima Pasechnik, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/32257

[mkoeppe]

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1051039345

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,4 @@
 As noted in [#32001 comment:1](https://github.com/sagemath/sage/issues/32001#comment:1), pynac fails on `cygwin-standard`. We add a patch to `singular` to fix this
+
+https://github.com/Singular/Singular/pull/1109
+

[mkoeppe]

Branch: u/mkoeppe/cygwin_patch_for_singular

[mkoeppe]

comment:4

This does the job.

---

New commits:

d4156f7

build/pkgs/singular/patches/0001-factory-canonicalform.h-Add-more-FACTORY_PUBLIC.patch: New

[mkoeppe]

Commit: d4156f7

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
 As noted in [#32001 comment:1](https://github.com/sagemath/sage/issues/32001#comment:1), pynac fails on `cygwin-standard`. We add a patch to `singular` to fix this
 
-https://github.com/Singular/Singular/pull/1109
+https://github.com/Singular/Singular/pull/1109 (merged)
 

[dimpase]

comment:5

OK, great.

[dimpase]

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1051039345 to Dima Pasechnik

[slel]

comment:6

I applied this locally on Cygwin on Windows 10.
It works and makes #32001 work.

I'm curious how you figured out those changes
would solve this problem! Thank you!

[slel]

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Samuel Lelièvre

[mkoeppe]

comment:7

Thanks for testing! The fix was just an extension of one that Hans Schoenemann did earlier this year to get Cygwin working.

[vbraun]

Changed branch from u/mkoeppe/cygwin_patch_for_singular to d4156f7