Replace NumberField_generic.__latex_variable_name by ._latex_names

[mkoeppe]

as observed in #30360,

sage: K3.<a> = NumberField(x^3+x^2+1, latex_name=['alpha'])                                                                         
sage: K3.latex_variable_names()                                                                                                     
['a']
sage: K3.latex_variable_name()                                                                                                      
'alpha'

We fix this by changing the attribute __latex_variable_name, only used in NumberField_generic, to the widely used _latex_names.

We also deprecate the method latex_variable_name, which is also only used in sage.rings.number_field, changing its uses to latex_variable_names.

CC: @kliem @videlec @tscrim

Component: number fields

Author: Matthias Koeppe

Branch/Commit: da551dc

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30372

[mkoeppe]

Description changed:

--- 
+++ 
@@ -11,3 +11,6 @@
 We fix this by changing the attribute `__latex_variable_name`, only used in `NumberField_generic`, to the widely used `_latex_name`.
 
 
+We also deprecate the method `latex_variable_name`, which is also only used in `sage.rings.number_field`, changing its uses to `latex_variable_names`.
+
+

[mkoeppe]

Description changed:

--- 
+++ 
@@ -8,7 +8,7 @@
 'alpha'
 ```
 
-We fix this by changing the attribute `__latex_variable_name`, only used in `NumberField_generic`, to the widely used `_latex_name`.
+We fix this by changing the attribute `__latex_variable_name`, only used in `NumberField_generic`, to the widely used `_latex_names`.
 
 
 We also deprecate the method `latex_variable_name`, which is also only used in `sage.rings.number_field`, changing its uses to `latex_variable_names`.

[mkoeppe]

Branch: u/mkoeppe/replace_numberfield_generic___latex_variable_name_by___latex_name

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

New commits:

1842e47

sage.rings.number_field.number_field.NumberField_generic: Use _latex_names instead of __latex_variable_name, deprecate .latex_variable_name()

[mkoeppe]

Commit: 1842e47

[sagetrac-git]

Changed commit from 1842e47 to 6697bca

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6697bca

Fixup

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:7

Green patchbot => positive review.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

da551dc

src/sage/rings/number_field/number_field.py: Fix error found by pyflakes

[sagetrac-git]

Changed commit from 6697bca to da551dc

[mkoeppe]

comment:9

Thank you! All green

[vbraun]

Changed branch from u/mkoeppe/replace_numberfield_generic___latex_variable_name_by___latex_name to da551dc