Upgrade to cryptominisat 5.6.6 (and make it an optional package again)

[videlec]

Update cryptominisat to 5.6.6.

Tarball at

https://github.com/msoos/cryptominisat/archive/5.6.6.tar.gz

(to be renamed cryptominisat-5.6.6.tar.gz)

Compilation issues which had caused cryptominisat to be downgraded from "optional" to "experimental" in Sage are fixed in the 5.6.x releases. Note that old installations have to be removed because of interference of header files (see e.g. issue 5).

CC: @sagetrac-tmonteil @embray @saraedum @slel

Component: packages: optional

Keywords: cryptominisat, upgrade

Author: Vincent Delecroix, Thierry Monteil

Branch/Commit: d483861

Reviewer: Jeroen Demeyer, Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/25480

[videlec]

Commit: cbf02c9

[videlec]

comment:1

Experimental branch (for the prerelease). I will update the branch as soon as the definitive release is out. Please test in the meantime (works for me with Python2 but did not check with Python3).

---

New commits:

cbf02c9

25480: upgrade cryptominisat

[videlec]

Branch: u/vdelecroix/25480

[slel]

Changed keywords from none to cryptominisat, upgrade

[slel]

Description changed:

--- 
+++ 
@@ -1,3 +1,7 @@
-Upstream cryptominisat fixed compilation issues. There is a prerelease available at
+Cryptominisat 5.6.1 is now available:
 
-    https://github.com/msoos/cryptominisat/releases/tag/5.6.0
+- https://github.com/msoos/cryptominisat/releases/
+
+It fixes compilation issues which had made us downgrade it
+from "optional" to "experimental" in Sage.
+

[slel]

Description changed:

--- 
+++ 
@@ -1,7 +1,9 @@
-Cryptominisat 5.6.1 is now available:
+Cryptominisat 5.6.3 is now available:
 
-- https://github.com/msoos/cryptominisat/releases/
+- releases: https://github.com/msoos/cryptominisat/releases/
+- tarball: https://github.com/msoos/cryptominisat/archive/5.6.3.tar.gz
 
-It fixes compilation issues which had made us downgrade it
-from "optional" to "experimental" in Sage.
+Compilation issues which had caused cryptominisat to be
+downgraded from "optional" to "experimental" in Sage
+are fixed in the 5.6.x releases.
 

[slel]

comment:4

Cryptominisat 5.6.3 was released, do you mind using that instead of 5.6.1?

[videlec]

Description changed:

--- 
+++ 
@@ -1,9 +1,9 @@
-Cryptominisat 5.6.3 is now available:
+Update cryptominisat to 5.6.3.
 
-- releases: https://github.com/msoos/cryptominisat/releases/
-- tarball: https://github.com/msoos/cryptominisat/archive/5.6.3.tar.gz
+Tarball at
 
-Compilation issues which had caused cryptominisat to be
-downgraded from "optional" to "experimental" in Sage
-are fixed in the 5.6.x releases.
+    https://github.com/msoos/cryptominisat/archive/5.6.3.tar.gz
 
+(to be renamed cryptominisat-5.6.3.tar.gz)
+
+Compilation issues which had caused cryptominisat to be downgraded from "optional" to "experimental" in Sage are fixed in the 5.6.x releases.

[videlec]

comment:7

Still not able to build crypotiminisat (archlinux and gcc 8.1.1)

[ 84%] Building CXX object cmsat5-src/CMakeFiles/libcryptominisat5.dir/cryptominisat.cpp.o
cd /opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src/cmsat5-src && /usr/lib/ccache/bin/g++  -DBOOST_TEST_DYN_LINK -DUSE_GAUSS -DUSE_M4RI -DUSE_ZLIB -Dlibcryptominisat5_EXPORTS -I/opt
/sage/local/include -I/opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src -I/opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src/cmsat5-src  -mtune=native -Wall -Wextra -Wunused 
-Wsign-compare -fno-omit-frame-pointer -Wtype-limits -Wuninitialized -Wno-deprecated -Wstrict-aliasing -Wpointer-arith -Wpointer-arith -Wformat-nonliteral -Winit-self -Wparentheses -Wunreacha
ble-code -ggdb3 -Wlogical-op -Wrestrict -Wnull-dereference -Wdouble-promotion -Wshadow -Wformat=2 -Wextra-semi -pedantic -Wno-class-memaccess -fPIC   -g -pthread -O2 -mtune=native -fPIC -std=
gnu++11 -o CMakeFiles/libcryptominisat5.dir/cryptominisat.cpp.o -c /opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src/src/cryptominisat.cpp
../src/cryptominisat.cpp:1059:17: error: no declaration matches 'void CMSat::SATSolver::start_getting_small_clauses(uint32_t, uint32_t)'
 void DLL_PUBLIC SATSolver::start_getting_small_clauses(uint32_t max_len, uint32_t max_glue)
                 ^~~~~~~~~
../src/cryptominisat.cpp:1059:17: note: no functions named 'void CMSat::SATSolver::start_getting_small_clauses(uint32_t, uint32_t)'
In file included from ../src/cryptominisat.cpp:24:
../../../../../../../include/cryptominisat5/cryptominisat.h:41:11: note: 'class CMSat::SATSolver' defined here
     class SATSolver
           ^~~~~~~~~
../src/cryptominisat.cpp:1065:17: error: no declaration matches 'bool CMSat::SATSolver::get_next_small_clause(std::vector<CMSat::Lit>&)'
 bool DLL_PUBLIC SATSolver::get_next_small_clause(std::vector<Lit>& out)
                 ^~~~~~~~~
../src/cryptominisat.cpp:1065:17: note: no functions named 'bool CMSat::SATSolver::get_next_small_clause(std::vector<CMSat::Lit>&)'
In file included from ../src/cryptominisat.cpp:24:
../../../../../../../include/cryptominisat5/cryptominisat.h:41:11: note: 'class CMSat::SATSolver' defined here
     class SATSolver
           ^~~~~~~~~
../src/cryptominisat.cpp:1071:17: error: no declaration matches 'void CMSat::SATSolver::end_getting_small_clauses()'
 void DLL_PUBLIC SATSolver::end_getting_small_clauses()
                 ^~~~~~~~~
../src/cryptominisat.cpp:1071:17: note: no functions named 'void CMSat::SATSolver::end_getting_small_clauses()'
In file included from ../src/cryptominisat.cpp:24:
../../../../../../../include/cryptominisat5/cryptominisat.h:41:11: note: 'class CMSat::SATSolver' defined here
     class SATSolver
           ^~~~~~~~~
make[4]: *** [cmsat5-src/CMakeFiles/libcryptominisat5.dir/build.make:596: cmsat5-src/CMakeFiles/libcryptominisat5.dir/cryptominisat.cpp.o] Error 1
make[4]: Leaving directory '/opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src'
make[3]: *** [CMakeFiles/Makefile2:198: cmsat5-src/CMakeFiles/libcryptominisat5.dir/all] Error 2
make[3]: Leaving directory '/opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src'
make[2]: *** [Makefile:130: all] Error 2
make[2]: Leaving directory '/opt/sage/local/var/tmp/sage/build/cryptominisat-5.6.3/src'
********************************************************************************
Error building cryptominisat-5.6.3
********************************************************************************