Prompting about experimental packages: `sage -i -y`, `sage -i -n`

[mkoeppe]

This is a follow-up on:

• line buffering in sage-logger causes "hang" due to invisible prompt when installing experimental packages #20884 closed defect (fixed): line buffering in sage-logger causes "hang" due to invisible prompt when installing experimental packages
• make V=0 should silence the build #21539 positive_review enhancement: make V=0 should silence the build --- which solved the 'buffered prompting problem' by using /dev/tty

This ticket adds options -y ("yes"), -n ("no") that get rid of user prompting for non-interactive installs of experimental/old-style packages.

Also if there is no controlling terminal, then -n is implied for experimental packages and -y is implied for old-style optional packages. (On Linux, this situation can be tested by using setsid (for Mac OS X: see here) or by using ssh without the -t option.)

The ticket changes the exit status from 0 to 1 if the user declines to install the package. Previously, the system would record a successful installation in $SAGE_LOCAL/var/lib/sage/installed/.

Moreover, for experimental packages, sage -info no longer warns/prompts.
Instead, the package type is simply printed. None of our packages is so dangerous that merely viewing the SPKG.txt will cause harm.

CC: @jdemeyer @embray @vbraun @kcrisman @dimpase @videlec @novoselt @nexttime

Component: build

Author: Erik Bray, Matthias Koeppe

Branch: 18ac798

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/21082

[embray]

comment:1

I'm probably not going to bother. Somebody else is welcome to take my branch and continue the work off it. I've wasted enough time on this.

[jdemeyer]

New commits:

035e1d8

A simplified approach to #20884

[jdemeyer]

Commit: 035e1d8

[jdemeyer]

Branch: u/embray/ticket-20884-squashed

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,3 +1,12 @@
 This is a follow-up on:
 - #20884 closed defect (fixed): line buffering in sage-logger causes "hang" due to invisible prompt when installing experimental packages
+- #21539 positive_review enhancement: make V=0 should silence the build --- which solved the 'buffered prompting problem' by using `/dev/tty`
 
+For non-interactive installs of experimental packages, we should add options `-y` ("yes"), `-n` ("no") that get rid of prompting. 
+
+Also if there is no controlling terminal, then `-n` should be implied. (On Linux, this situation can be tested [by using `setsid`](http://unix.stackexchange.com/questions/68574/invoke-a-command-script-disconnected-from-the-controlling-terminal).)
+
+The branch on the ticket has some code in this direction, but it's not complete.
+
+Also, this needs to be documented - #20937.
+

[mkoeppe]

Changed branch from u/embray/ticket-20884-squashed to u/mkoeppe/ticket-20884-squashed

[mkoeppe]

Author: Erik Bray, Matthias Koeppe

[mkoeppe]

Changed commit from 035e1d8 to 928bc8f

[mkoeppe]

comment:5

The branch now on the ticket implements "-y".

---

New commits:

9d85ee1	sage-logger: If no prefix, do not use sed
5df6cd9	sage-spkg: Handle -y argument
928bc8f	sage-spkg: Really handle -y argument

[sagetrac-git]

Changed commit from 928bc8f to 4b75f62

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b587aa4	sage-spkg: Nonzero exit status if user says no to dangerous package
5f30555	sage -info: Don't warn about experimental packages
9392c6a	sage -info: Print package type
16cbbf2	sage -i: If -n provided, don't download old-style spkg
4b75f62	sage -i: Handle -n and no-tty situation

[sagetrac-git]

Changed commit from 4b75f62 to 787b962

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

787b962

Add 'sage -i' options -y, -n to help messages

[mkoeppe]

comment:8

All features described are now implemented. Ready for review.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,11 +2,15 @@
 - #20884 closed defect (fixed): line buffering in sage-logger causes "hang" due to invisible prompt when installing experimental packages
 - #21539 positive_review enhancement: make V=0 should silence the build --- which solved the 'buffered prompting problem' by using `/dev/tty`
 
-For non-interactive installs of experimental packages, we should add options `-y` ("yes"), `-n` ("no") that get rid of prompting. 
+This ticket adds options `-y` ("yes"), `-n` ("no") that get rid of user prompting for non-interactive installs of experimental/old-style packages.
 
-Also if there is no controlling terminal, then `-n` should be implied. (On Linux, this situation can be tested [by using `setsid`](http://unix.stackexchange.com/questions/68574/invoke-a-command-script-disconnected-from-the-controlling-terminal).)
+Also if there is no controlling terminal, then `-n` is implied for experimental packages and `-y` is implied for old-style optional packages. (On Linux, this situation can be tested [by using `setsid`](http://unix.stackexchange.com/questions/68574/invoke-a-command-script-disconnected-from-the-controlling-terminal) or by using ssh without the `-t` option.)
 
-The branch on the ticket has some code in this direction, but it's not complete.
+The ticket changes the exit status from 0 to 1 if the user declines to install the package. Previously, the system would record a successful installation in `$SAGE_LOCAL/var/lib/sage/installed/`. 
 
-Also, this needs to be documented - #20937.
+Moreover, for experimental packages, `sage -info` no longer warns/prompts.
+Instead, the package type is simply printed. None of our packages is so dangerous that merely viewing the SPKG.txt will cause harm.
 
+
+
+