prun is not preparsed -- potentially very confusing

[williamstein]

If one uses the Python profiler through Sage's Ipython command line, the input line is not preparsed, which is potentially very confusing. E.g., this should print 256:

sage: %prun print 2^8
10
         2 function calls in 0.000 CPU seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.000    0.000 <string>:1(<module>)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}

sage: 

Component: user interface

Author: Mike Hansen

Reviewer: Ross Kyprianou

Merged: sage-4.3.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/2054

[williamstein]

comment:1

Fernando Perez to me
	
show details 9:15 PM (18 minutes ago)
	
	
	
Reply
	
	
Hi William,

On Feb 5, 2008 7:46 AM, William Stein <wstein@gmail.com> wrote:
> Fernando,
>
> Any hints about how I could make the argument to %prun get preparsed?

sorry for the delay, I just wanted to let you know that I don't have a
quick solution to this right now, and I'm swamped with moving/home
sale issues, so for a couple of weeks my coding time is reduced to
exactly zero.

I'll keep this in my inbox, starred, so once I get to Berkeley I can
fix it.  It's not difficult, I just don't have a spare hour right now
to code it and test it, sorry.

Cheers,

f

[mwhansen]

Attachment: scripts_2054.patch.gz

[mwhansen]

Author: Mike Hansen

[sagetrac-rossk]

comment:3

Is this an error on my part?

/scratch/rossk/sage-4.3.2/devel/sage$ hg qimport https://github.com/sagemath/sage-prod/files/10639224/scripts_2054.patch.gz
adding scripts_2054.patch to series file

/scratch/rossk/sage-4.3.2/devel/sage$ hg qpush
applying scripts_2054.patch
unable to find 'ipy_profile_sage.py' for patching
1 out of 1 hunks FAILED -- saving rejects to file ipy_profile_sage.py.rej
patch failed, unable to continue (try -v)
ipy_profile_sage.py: No such file or directory
patch failed, rejects left in working dir
errors during apply, please fix and refresh scripts_2054.patch

[mwhansen]

comment:4

Hello,

You need to be in /scratch/rossk/sage-4.3.2/local/bin in order to be in the repository which the patch applies to.

[sagetrac-rossk]

comment:5

Replying to @mwhansen:

Hello,

You need to be in /scratch/rossk/sage-4.3.2/local/bin in order to be in the repository which the patch applies to.

Thanks - it installed and built ok :-)

(I suppose look in the patch next time to know which folder I should be in?)

Will run a few tests, do the doctests and hopefully we'll knock this one over soon.

[sagetrac-rossk]

comment:6

Tested the patch with a few statements that exercised the preparser. e.g.

sage: %prun 123456789123456789123456789123456789123456789123456789.factor()

sage: %prun print integrate(log(x)^(2^3),x)

Pre-patch statements like these crashed or gave incorrect answers if prefixed with "%prun ".
Post-patch the statements give the same answers with or without "%prun" (and all doctests passed).
Positive review