-
-
Notifications
You must be signed in to change notification settings - Fork 704
Open
Description
The sha an function:
sage: E = EllipticCurve('37a')
sage: Sha = E.sha(); Sha
<class 'sage.schemes.elliptic_curves.sha.Sha'>
sage: Sha.an()
1
has help that at the beginning misleadingly suggests that it is provably correct when the analytic rank is 1. Looking at the code, it is clear that currently it is not provably correct except when the rank is 0 and a Manin constant hypothesis holds (which does hold for Cremona's curves).
Fix:
- Have a proof=False flag that keeps the current implementation
- Have a proof=True flag that fails if the Manin constant isn't known by a theorem to be <=2, and which runs new provably correct code in the case of analytic rank 1.
CC: @JohnCremona
Component: elliptic curves
Issue created by migration from https://trac.sagemath.org/ticket/1848