update 4ti2 to version 1.6

[dimpase]

version 1.6 is released.

Intsall the updated spkg and apply attachment: 42.patch

CC: @novoselt @miguelmarco @sagetrac-dperkinson @sagetrac-mhampton

Component: packages: optional

Keywords: 4ti2

Author: Dmitrii Pasechnik

Reviewer: Volker Braun

Merged: sage-5.13.beta1

Issue created by migration from https://trac.sagemath.org/ticket/15172

[dimpase]

comment:1

at the moment there is one test failure, which only occurs from sage -t run, but I can't reproduce it interactively:

$ ../../sage -t --optional='sage,4ti2' sage/interfaces/four_ti_2.py
Running doctests with ID 2013-09-07-09-09-54-b455bb50.
Doctesting 1 file.
sage -t sage/interfaces/four_ti_2.py
**********************************************************************
File "sage/interfaces/four_ti_2.py", line 284, in sage.interfaces.four_ti_2.FourTi2.call
Failed example:
    four_ti_2.read_matrix("test_file.gro") # optional - 4ti2
Expected:
    [-5  0  2]
    [-5  3  0]
Got:
    []
**********************************************************************
1 item had failures:
   1 of   5 in sage.interfaces.four_ti_2.FourTi2.call
    [50 tests, 1 failure, 0.55 s]
----------------------------------------------------------------------
sage -t sage/interfaces/four_ti_2.py  # 1 doctest failed

[dimpase]

Description changed:

--- 
+++ 
@@ -1,3 +1,3 @@
 version 1.6 is [released](http://4ti2.de).
 
-The updated [spkg http://boxen.math.washington.edu/home/dima/packages/4ti2-1.6.spkg]
+Intsall the updated [spkg](http://boxen.math.washington.edu/home/dima/packages/4ti2-1.6.spkg) and apply [attachment: 42.patch](https://github.com/sagemath/sage-prod/files/10658420/42.patch.gz)

[jdemeyer]

comment:4

Why add # optional - 4ti2 where it was not needed before?

[jdemeyer]

comment:5

The following

        cwd = os.getcwd() # Save working directory in order to restore it.
        os.chdir(self.directory())

        subprocess.call(cmd, shell=True)

        os.chdir(cwd) # Restore previous working directory.

should be replaced by

        subprocess.call(cmd, shell=True, cwd=self.directory())

[novoselt]

comment:6

As I understand in the patch "-q" is for quiet mode, but why there is a need to silence stderr explicitly? Shouldn't commands output no errors if used correctly?

[dimpase]

comment:7

Replying to @novoselt:

As I understand in the patch "-q" is for quiet mode, but why there is a need to silence stderr explicitly? Shouldn't commands output no errors if used correctly?

there is no '-q' switch for ppi, for some reason. So its stderr output needs to be silenced.