Upgrade Maxima to 5.33.0

[dimpase]

This is a continuation of #13364, and aims at including more upstream bug fixes, which e.g. fix an
issue reported on sage-support,
which was reported as Maxima bug 2535, and marked there as closed in post-5.29.1.

Fixes #11894, #13526, #13712, #14209, #14306, #15386 and possibly other Maxima-related bugs.

Ought to fix #13733 (but loading the abs_integrate package currently causes this to fail).

Ought to fix #8728 (but Maxima asks for more constraints which follow from the existing ones).

Does not fix #14591, #14677, #15033.

tarball: http://homepages.warwick.ac.uk/staff/P.Bruin/sage/maxima-5.33.0.tar.bz2

Note about the existing maxima_bug_2526.patch: ​the bug was marked "closed" in the Maxima bug tracking system, but the commit somehow disappeared from the Maxima repository and the bug has been reopened. Hence this patch is still needed to fix it.

CC: @SnarkBoojum

Component: packages: standard

Keywords: sd48

Author: Peter Bruin

Branch: a130eed

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/13973

[kcrisman]

Changed dependencies from 13364 to #13364

[kcrisman]

comment:2

So for instance going at least as far as the fix for #13733 would be good.

[zimmermann6]

comment:3

while we are at it, it seems strange to me that sage/interfaces/maxima_abstract.py contains a doctest for the maxima version used:

File "/localdisk/tmp/sage-5.5/devel/sage-12615b/sage/interfaces/maxima_abstract.py", line 422:
    sage: maxima.version()
Expected:
    '5.26.0'
Got:
    '5.29.1'

What really matters is the functionality provided, not the actual version?
Does Sage check the actual version of each component?

Paul

[dimpase]

comment:4

Replying to @zimmermann6:

while we are at it, it seems strange to me that sage/interfaces/maxima_abstract.py contains a doctest for the maxima version used:

File "/localdisk/tmp/sage-5.5/devel/sage-12615b/sage/interfaces/maxima_abstract.py", line 422:
    sage: maxima.version()
Expected:
    '5.26.0'
Got:
    '5.29.1'

seems that https://github.com/sagemath/sage-prod/files/10656171/doctests.2.patch.gz
was not installed into the Sage installation you work with.

What really matters is the functionality provided, not the actual version?
Does Sage check the actual version of each component?

Sage provides versions at least for some other components, e.g. gap.version()

Sometimes it might be useful; AFAIK some optional packages check this.

Dima

Paul

[zimmermann6]

comment:5

Dima, I don't object about providing a function maxima_version(), but checking it returns a particular value.

Paul

[dimpase]

comment:6

Replying to @zimmermann6:

Dima, I don't object about providing a function maxima_version(), but checking it returns a particular value.

well, one would like to test Sage functions... How else would you check that it works and returns something meaningful?

Paul

[zimmermann6]

comment:7

we could for example check that the version is of the form x.y.z, or is greater than or equal to a given number.

Paul

[zimmermann6]

comment:8

see #14306 (issue fixed in Maxima git)

Paul

[kcrisman]

comment:9

Also note that Maxima is now at 5.30.0.

[kiwifb]

comment:10

Yes it is at 5.30.0. No check from sage-on-gentoo on whether it works so far because the maxima ecl library building is currently broken for that particular version - an adsf upgrade problem in gentoo.

I second checking the form of the version returned rather than the value. That would make my life easier when R, maxima are upgraded in s-o-g independently of sage itself (and without side effects at leat in doctests).

[jdemeyer]

comment:12

I'll try making a new Maxima spkg just to see what happpens...