Tc sig env merging #11
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This resolves the problem that was detected in #10.
I first removed the workaround where a signature file depends on all the signature files that came before it. Surprisingly, I didn't break any unit tests by doing that. This is something to pay closer attention to in the future.
Next, I've added my failing test case. Then I updated the merge code and my test case worked.
From now on I hope to inspire you to do every next change test driven. This would be a good preparation for the eventual draft PR.
Two more pointers I do want to mention:
ParallelTypeCheckingTests.fsprojproject. Your eventual PR will not be merged in using that. It is best to move the bits to the right projects instead.