Version 0.2 doesn't work with AMD formatter

[szwacz]

I can't get new transpiler to work with AMD formatter. Version 0.2 expects always to be one module (through moduleName), but every AMD module should be outputted to separate file. What happens is that all files are saved (one owerwrites another) to the same path (e.g. bundle.js).

I don't have good fix for this problem, so I'm starting this discussion. Some special magic value for moduleName which switches to "not bundling" behaviour comes to my mind, but this is dirty solution. Has anyone better idea?

[ryanseddon]

@rkusa @janjakubnanista any thoughts on this?

[janjakubnanista]

@ryanseddon New version of es6-module-transpiler supports bundle and commonjs formatters only by default. In order to output to AMD, you can use es6-module-transpiler-amd-formatter module.

[szwacz]

@janjakubnanista Yes, as I linked in my previous post official AMD formatter is what I'm using, and this issue is about this formatter. I'm not fluent in how the whole gulp -> es6 transpiler -> AMD formatter works, but by looking at code in this repo lib/index.js:

container.convert().forEach(function(converted) {
  var convertedAsFile = new gutil.File({
    path: moduleName + '.js'
  });

I think the problem is caused by this project. All files sent to gulp pipeline are forced to have the same name.

[janjakubnanista]

Oh sorry, I missed the start of discussion since I was reading it via gmail. I'll take a look since this was one of the trickier parts of the code. I'll get back to you ASAP.

[janjakubnanista]

@szwacz In meantime, you could work around this issue by creating multiple streams, one per module. Then, using merge-stream you could merge these streams and write output with one gulp.dest.

[janjakubnanista]

@ryanseddon @rkusa Hi guys, could you please review the pull request?

[rkusa]

@janjakubnanista Code looks fine. However, how to get the bundle formatter to work properly with these changes? I was thinking about something like:

gulp.task('bundle', function() {
  return gulp.src('src/**/*.js')
    .pipe(sourcemaps.init())
      .pipe(transpile({
        formatter: 'bundle'
      }))
      .pipe(concat('bundleName.js'))
    .pipe(sourcemaps.write('./'))
    .pipe(gulp.dest('dist'))
})

But I was not able to get this to work properly. Any ideas?

Edit: Seems to be an gulp-concat issue.

[janjakubnanista]

@rkusa The problem is that you are using concat before writing sourceMaps. I think this cannot be accomplished by simple gulp-concat, you have to use gulp-concat-sourcemap plugin.

[rkusa]

@janjakubnanista According to gulp-sourcemaps wiki is gulp-concat compatible to gulp-sourcemaps, i.e. it should be - in theory - possible to chain multiple plugins (e.g. gulp-es6-module-transpiler and gulp-concat) between the init and write calls. I could try to fix the gulp-concat issue (next week).

[janjakubnanista]

@rkusa I've added e2e tests for sourcemaps functionality. There were two problems - one with basePath property passed to converted file, another with double //# sourceMappingURL=... comment that should have not been added to converted files by our plugin (gulp-sourcemaps is responsible for this).