-
-
Couldn't load subscription status.
- Fork 12
fix: update message handling #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaseyvee
reviewed
Jul 31, 2024
| }) | ||
|
|
||
| setChatMessages(messageDict) | ||
| }, [props.messages]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| }, [props.messages]) | |
| }, [props.messages.length]) |
Shiti
reviewed
Aug 1, 2024
| } | ||
|
|
||
| useEffect(() => { | ||
| if (props.ws.onReceive) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| if (props.ws.onReceive) { | |
| if (props.ws) { |
kaseyvee
approved these changes
Aug 1, 2024
Shiti
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MessageSpaceprops.messagesis used to pass unprocessed messages from the page level.props.ws.onReceiveis used to receive and handle incoming messages from websocket. Original message and its update messages are combined into a single array and stored in thechatMessages({[messageId: string]: Message[]})) for quick data retrieval.Message[]which contains original message and update messages is passed toElementRenderer.ElementRendererrenders component with original message as well as updated data from update messages.PromptBuilderis updated since it useselementRenderer.ThreadableMessageScreenshots
Before
After