fix!: reorganize chart and vegalite and rename vegalite component #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: rename vagaLiteChart to vegaLite
lyjeileen
requested review from
Shiti,
florenceloi and
milliondreams
as code owners
kaseyvee
reviewed
May 22, 2024
BREAKING CHANGE: rename vegalite
Shiti
reviewed
May 23, 2024
src/components/types.ts
Outdated
|
|
||
| type VegaLiteOptions = EmbedOptions<string, Renderers> | ||
| export interface VegaLiteChartFormat extends DataFormat { | ||
| export interface VegaLiteVizFormat extends DataFormat { |
Contributor
There was a problem hiding this comment.
Maybe this should just be VegaLiteFormat
Suggested change
| export interface VegaLiteVizFormat extends DataFormat { | |
| export interface VegaLiteFormat extends DataFormat { |
Shiti
reviewed
May 23, 2024
src/components/types.ts
Outdated
|
|
||
| export type VegaLiteChartData = VegaLiteChartFormat & | ||
| Updates<VegaLiteChartFormat> | ||
| export type VegaLiteVizData = VegaLiteVizFormat & Updates<VegaLiteVizFormat> |
Contributor
There was a problem hiding this comment.
Suggested change
| export type VegaLiteVizData = VegaLiteVizFormat & Updates<VegaLiteVizFormat> | |
| export type VegaLiteData = VegaLiteFormat & Updates<VegaLiteFormat> |
Shiti
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
More storybook examples will be added in a follow-up PR
Before
After