fix: include file names in the message #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shiti
requested changes
May 1, 2024
Contributor
Shiti
left a comment
Shiti
left a comment
There was a problem hiding this comment.
I've suggested minor renames to clarify functionality.
|
|
||
| export default function MultimodalInput(props: MultimodalInputProps) { | ||
| const [fileCount, setFileCount] = useState(0) | ||
| const [fileList, setFileList] = useState<string[]>([]) |
Contributor
There was a problem hiding this comment.
Suggested change
| const [fileList, setFileList] = useState<string[]>([]) | |
| const [fileNames, setFileNames] = useState<string[]>([]) |
| useState<HTMLDivElement>() | ||
| const inputRef = useRef<HTMLDivElement>(null) | ||
| const hasAddedFiles = fileCount > 0 | ||
| const hasAddedFiles = fileList.length > 0 |
Contributor
There was a problem hiding this comment.
Suggested change
| const hasAddedFiles = fileList.length > 0 | |
| const hasAddedFiles = fileNames.length > 0 |
| props.ws.send(formattedMessage) | ||
| setMessageId(getUUID()) | ||
| setFileCount(0) | ||
| setFileList([]) |
Contributor
There was a problem hiding this comment.
Suggested change
| setFileList([]) | |
| setFileNames([]) |
|
|
||
| function handleFileCountChange(fileCountChange: 1 | -1) { | ||
| setFileCount((prev) => prev + fileCountChange) | ||
| function handleFileListChange(action: 'add' | 'remove', fileName: string) { |
Contributor
There was a problem hiding this comment.
Suggested change
| function handleFileListChange(action: 'add' | 'remove', fileName: string) { | |
| function handleFileUpdates(action: 'add' | 'remove', fileName: string) { |
| uploadFileEndpoint={props.uploadFileEndpoint} | ||
| deleteFileEndpoint={props.deleteFileEndpoint} | ||
| handleFileCountChange={handleFileCountChange} | ||
| handleFileListChange={handleFileListChange} |
Contributor
There was a problem hiding this comment.
Suggested change
| handleFileListChange={handleFileListChange} | |
| onFileUpdates={handleFileListChange} |
src/components/types.ts
Outdated
| UploaderProps, | ||
| | 'messageId' | ||
| | 'handleFileCountChange' | ||
| | 'handleFileListChange' |
Contributor
There was a problem hiding this comment.
Suggested change
| | 'handleFileListChange' | |
| | 'onFileUpdate' |
| }) | ||
| .catch(() => { | ||
| props.handleFileCountChange(1) | ||
| props.handleFileListChange('add', fileName) |
Contributor
There was a problem hiding this comment.
Suggested change
| props.handleFileListChange('add', fileName) | |
| props.onFileUpdate('add', fileName) |
| ...fileNamesRef.current, | ||
| [fileName]: fileNamesRef.current[fileName]--, | ||
| } | ||
| props.handleFileListChange('remove', fileName) |
Contributor
There was a problem hiding this comment.
Suggested change
| props.handleFileListChange('remove', fileName) | |
| props.onFileUpdate('remove', fileName) |
| }) | ||
| .catch((error) => { | ||
| props.handleFileCountChange(-1) | ||
| props.handleFileListChange('remove', fileName) |
Contributor
There was a problem hiding this comment.
Suggested change
| props.handleFileListChange('remove', fileName) | |
| props.onFileUpdate('remove', fileName) |
| setAddedFiles((prev) => [...prev, newAddedFile]) | ||
|
|
||
| props.handleFileCountChange(1) | ||
| props.handleFileListChange('add', fileName) |
Contributor
There was a problem hiding this comment.
Suggested change
| props.handleFileListChange('add', fileName) | |
| props.onFileUpdate('add', fileName) |
kaseyvee
reviewed
May 1, 2024
src/components/types.ts
Outdated
| messageId: string | ||
| /** A function to handle changes in the file count. Parent component should use this to track file count change and handle submit accordingly. */ | ||
| handleFileCountChange: (fileCountChange: 1 | -1) => void | ||
| /** A function to handle changes in the file list. Parent component should use this to track file names and handle submit accordingly. */ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /** A function to handle changes in the file list. Parent component should use this to track file names and handle submit accordingly. */ | |
| /** A function to handle changes in the file list. The parent component should use this to track file names and handle submit accordingly. */ |
Shiti
previously approved these changes
May 1, 2024
Shiti
approved these changes
May 1, 2024
Shiti
approved these changes
May 1, 2024
kaseyvee
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: The alert is only be shown in the storybook to show the content being sent.
Before
After